Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to Dokku and webpack asset handling #137

Merged
merged 58 commits into from Jan 18, 2020
Merged

Move to Dokku and webpack asset handling #137

merged 58 commits into from Jan 18, 2020

Conversation

duffn
Copy link
Member

@duffn duffn commented Jan 3, 2020

Description

This is a gigantic PR to move to handling static assets as well as moving to Heroku. The static asset updates were based upon a fresh new 1.4 Phoenix project and its defaults

  • Moves all static assets to /assets
  • Combine a few CSS files into a single site.css
  • Update all static assets to use Routes.static_path
  • Update local development environment to handle webpack
  • Add code reloading in dev.exs
  • Update prod.exs to handle Heroku setup
  • Add Dokku configuration files

TODO

  • Write up checklist for Heroku switchover.
  • Minify CSS files in vendor.
    Will be done by Cloudflare in Move DNS to Cloudflare #177.
  • Update Docker setup to work with webpack.
  • Update ansible-swsheets to work with this (if using DO).
    Will be using Dokku
  • Update CORS settings in prod #150 needs to be resolved before this is deployed (if using DO).
    Will be using Dokku

Closes #127.

# Conflicts:
#	.gitignore
#	assets/css/site.css
#	config/config.exs
#	lib/edge_builder/endpoint.ex
#	priv/static/css/bootstrap.min.css
#	web/templates/layout/app.html.eex
#	web/templates/page/index.html.eex
#	web/templates/profile/my_creations.html.eex
# Conflicts:
#	web/templates/character/list_view.html.eex
#	web/templates/layout/app.html.eex
#	web/templates/page/thanks.html.eex
#	web/templates/profile/profile_link.html.eex
#	web/templates/vehicle/list_view.html.eex
@codecov
Copy link

codecov bot commented Jan 5, 2020

Codecov Report

Merging #137 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #137   +/-   ##
======================================
  Coverage    93.3%   93.3%           
======================================
  Files          47      47           
  Lines         558     558           
======================================
  Hits          521     521           
  Misses         37      37

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update faffcde...163b49d. Read the comment docs.

@duffn duffn changed the title Move to Webpack asset handling Move to Heroku and webpack asset handling Jan 11, 2020
@duffn duffn marked this pull request as ready for review January 18, 2020 01:36
@duffn duffn changed the title Move to Heroku and webpack asset handling Move to Dokku and webpack asset handling Jan 18, 2020
@duffn duffn merged commit 5487a01 into swsheets:master Jan 18, 2020
@duffn duffn deleted the duffn/static-assets branch January 18, 2020 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use static asset compilation with Webpack
1 participant