Refactor terminal detection #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swsnr
force-pushed
the
refactor-terminal-detection
branch
from
ccf2595
to
a1ba186
Compare
swsnr
force-pushed
the
refactor-terminal-detection
branch
2 times, most recently
from
1df7c01
to
cf8c831
Compare
Introduce a separate TerminalApp struct to abstract terminal detection separately from terminal capabilities. Check $TERM before all other environment variables; terminal emulators always set this variable and if it's something other than xterm-256colors it's definitely accurate. Closes GH-230
swsnr
force-pushed
the
refactor-terminal-detection
branch
from
cf8c831
to
eedb1f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a separate
TerminalAppstruct to abstract terminal detection separately from terminal capabilities.Check
$TERMbefore all other environment variables; terminal emulators always set this variable and if it's something other thanxterm-256colorsit's definitely accurate.Closes #230