Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move focus starting point on anchor scroll #44

Closed
wants to merge 13 commits into from

Conversation

daun
Copy link
Member

@daun daun commented Mar 29, 2024

Description

  • Solve Feature: Move focus when handling same-page links #43
  • Move focus to right before an anchor on anchor scroll
  • Requires an ugly invisible-element workaround due to Safari
  • Switch content focus to new method as well, remove notes about no-longer-required styling
  • Works great in major browsers, tested in local playground
  • Caveat: resets focus to body on screen readers, so not ready to merge yet

Checks

  • The PR is submitted to the master branch
  • The code was linted before pushing (npm run lint)
  • All tests are passing (npm run test)
  • New or updated tests are included
  • The documentation was updated as required

@daun daun closed this Apr 12, 2024
@daun daun deleted the feature/focus-starting-point branch April 12, 2024 09:16
@daun daun mentioned this pull request Apr 12, 2024
5 tasks
@daun
Copy link
Member Author

daun commented Apr 12, 2024

Closed in favor of #55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Released
Development

Successfully merging this pull request may close these issues.

None yet

1 participant