Focus anchor link targets

[daun]

Description

• Solve Feature: Move focus when handling same-page links #43
• Supersedes Move focus starting point on anchor scroll #44
• Move focus to anchor link targets on anchor scroll
• Moving the focus starting point (as opposed to focussing directly) breaks down in screen readers
• Correct screen reader implementation requires direct focus and a permanent tabindex
• Tested to work in VoiceOver, NVDA and JAWS

Also

• Refactored focus and announcement methods into utility functions
• Make them more testable and allow better minification :)

Checks

• The PR is submitted to the master branch
• The code was linted before pushing (npm run lint)
• All tests are passing (npm run test)
• New or updated tests are included
• The documentation was updated as required

Notes

• Closes Feature: Move focus when handling same-page links #43

[hirasso]

Nice! As already mentioned in one of my inline comments, I have to rely on you regarding manual tests right now.

It's a shame that all your research in #44 didn't work out with screen readers. But it's great that we are landing on a robust solution!

[daun]

Knowing exactly why something won't work is almost as good as getting it to work 🧃

[daun]

Updated with your suggested changes. Feel free to approve now or whenever you get a chance to test this. Since we're not yet releasing anything, I'd opt for merging now so we can get started on the tests 🚀

[hirasso]

bling