Subcell: Add TciOnFdGrid mutator for NewtonianEuler #3199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kidder
changed the title
kidder
requested changes
May 27, 2021
tests/Unit/Evolution/Systems/NewtonianEuler/Subcell/Test_TciOnFdGrid.cpp
Outdated
Show resolved
Hide resolved
fmahebert
reviewed
May 28, 2021
| min(get(get<Pressure>(dg_grid_prim_vars)))) < | ||
| min_pressure_allowed or | ||
| evolution::dg::subcell::persson_tci(dg_mass_density, dg_mesh, | ||
| persson_exponent, 1.0e-18) or |
There was a problem hiding this comment.
Can you make a constexpr double persson_tci_epsilon = 1.0e-18; as in the other TCI?
| * minimum density and pressure on both the DG and subcell mesh are above | ||
| * \f$10^{-18}\f$, and runs the Persson TCI on the density and pressure on the | ||
| * DG grid. The reason for applying the Persson TCI to both the density and | ||
| * pressure is to flag cells at contact discontinuities. |
There was a problem hiding this comment.
Update this to match the newer text in the other TCI
Also, can you explain why you check both grids in a function "TciOnFdGrid" ?
nilsdeppe
force-pushed
the
subcell_ne_tci_on_fd_grid
branch
from
a50ed29
to
92d0487
Compare
|
I've rebased and pushed a fixup. Thanks for the reviews! |
kidder
requested changes
Jun 1, 2021
| * present in the FD solution. | ||
| * - runs the Persson TCI on the density and pressure on the DG grid. The reason | ||
| * for applying the Persson TCI to both the density and pressure is to flag | ||
| * cells at contact discontinuities. The Persson TCI is only works with |
|
LGTM, please squash |
nilsdeppe
force-pushed
the
subcell_ne_tci_on_fd_grid
branch
from
92d0487
to
7efffda
Compare
|
I've squashed. Thanks for reviewing :) |
kidder
approved these changes
Jun 2, 2021
fmahebert
approved these changes
Jun 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Add the troubled-cell indicator on the FD grid for NewtonianEuler.
Upgrade instructions
Code review checklist
make docto generate the documentation locally intoBUILD_DIR/docs/html.Then open
index.html.code review guide.
bugfixormajor new featureif appropriate.Further comments