Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warnings from GNU grep 3.8 #4681

Merged
merged 1 commit into from
Feb 2, 2023
Merged

Fix warnings from GNU grep 3.8 #4681

merged 1 commit into from
Feb 2, 2023

Conversation

wthrowe
Copy link
Member

@wthrowe wthrowe commented Feb 1, 2023

  • ! has no special meaning, so should not be escaped.
  • GREP_COLOR is now deprecated and warns unless the replacement GREP_COLORS is also defined.

Proposed changes

Upgrade instructions

Code review checklist

  • The code is documented and the documentation renders correctly. Run
    make doc to generate the documentation locally into BUILD_DIR/docs/html.
    Then open index.html.
  • The code follows the stylistic and code quality guidelines listed in the
    code review guide.
  • The PR lists upgrade instructions and is labeled bugfix or
    new feature if appropriate.

Further comments

@wthrowe
Fix warnings from GNU grep 3.8
504dfe7 
* ! has no special meaning, so should not be escaped.
* GREP_COLOR is now deprecated and warns unless the replacement
  GREP_COLORS is also defined.
@nilsdeppe nilsdeppe merged commit 95a8374 into sxs-collaboration:develop Feb 2, 2023
@nilsvu nilsvu added the bugfix label Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilsdeppe nilsdeppe nilsdeppe approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wthrowe @nilsdeppe @nilsvu