-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dropping of carriage returns #129
Comments
Hi there... Do you think you may have some time to take a look at this? |
Yes, this is in my TODO list. Unfortunately, I am blocked badly with work these days. Will try my best to cut some time for it |
Was just bumping in case it fell off the radar. Please don't feel any pressure. |
@brettz9 please check out the |
Fixed in |
Great...this new approach was a good way to go, I think. Thanks! |
We had an issue reported at gajus/eslint-plugin-jsdoc#745 regarding carriage returns being dropped.
It appears that in the
splitLines
function, asplit
is taking place which may consume the carriage return, but joins are not adding back what was found to be there.Would it work and be enough to just drop the matching of
\r?
in the split regex (or make its consumption optional), letting consumers deal with stripping out any unwanted carriage returns?The text was updated successfully, but these errors were encountered: