Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve generation of HTML for the hydrate example. #657

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

lukechu10
Copy link
Collaborator

This changes the hydrate app to render the HTML when using cargo run so that we no longer need to manually update the HTML.

Closes #656

This changes the hydrate app to render the HTML when using `cargo run` so that we no longer need to manually update the HTML.
@lukechu10 lukechu10 added the A-examples Area: examples label Feb 1, 2024
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a7bec19) 61.06% compared to head (c6229a9) 60.67%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #657      +/-   ##
==========================================
- Coverage   61.06%   60.67%   -0.40%     
==========================================
  Files          54       54              
  Lines        8985     8783     -202     
==========================================
- Hits         5487     5329     -158     
+ Misses       3498     3454      -44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukechu10
Copy link
Collaborator Author

CI failure is caused by new Clippy lint. Will fix another time.

@lukechu10 lukechu10 merged commit 1161393 into sycamore-rs:master Feb 1, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-examples Area: examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hydrate example has a javascript error and does not work
1 participant