Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: convert video from mov to webm to fix render issue on firefox #120

Merged
merged 2 commits into from
Jan 9, 2024
Merged

fix: convert video from mov to webm to fix render issue on firefox #120

merged 2 commits into from
Jan 9, 2024

Conversation

wainola
Copy link
Contributor

@wainola wainola commented Jan 9, 2024

This PR fix render issue of video on firefox.
Closes #119

@LyonSsS LyonSsS mentioned this pull request Jan 9, 2024
Closed
haochizzle
haochizzle approved these changes Jan 9, 2024
View reviewed changes
Copy link
Collaborator

@haochizzle haochizzle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@haochizzle haochizzle merged commit 14c96d2 into develop Jan 9, 2024
1 check passed
@haochizzle haochizzle deleted the fix/firefox-video-issue branch January 9, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haochizzle haochizzle haochizzle approved these changes

@MakMuftic MakMuftic Awaiting requested review from MakMuftic

@LyonSsS LyonSsS Awaiting requested review from LyonSsS

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Embedded documentation videos cannot be rendered in Firefox
2 participants
@wainola @haochizzle