Fixes #40 and #53 Move evil-nerd-commenter to extensions

Work-around a current bug in evil-nc with 24.4 byte-compilation

.gitmodules

@@ -42,3 +42,6 @@
 [submodule "contrib/syl20bnr/extensions/o-blog"]
 	path = contrib/syl20bnr/extensions/o-blog
 	url = https://github.com/renard/o-blog.git
+[submodule "spacemacs/extensions/evil-nerd-commenter"]
+	path = spacemacs/extensions/evil-nerd-commenter
+	url = https://github.com/redguardtoo/evil-nerd-commenter

spacemacs/extensions.el

@@ -13,6 +13,7 @@
     centered-cursor
     dos
     emoji-cheat-sheet
+    evil-nerd-commenter
     evil-org-mode
     evil-plugins
     helm-rcirc
@@ -51,6 +52,19 @@
   (use-package emoji-cheat-sheet
     :commands emoji-cheat-sheet))
 
+(defun spacemacs/init-evil-nerd-commenter ()
+  (use-package evil-nerd-commenter
+    :init
+    (progn
+      (evil-leader/set-key
+        "ncl" 'evilnc-comment-or-uncomment-lines
+        "nct" 'evilnc-quick-comment-or-uncomment-to-the-line
+        "ncy" 'evilnc-copy-and-comment-lines
+        "ncp" 'evilnc-comment-or-uncomment-paragraphs
+        "ncr" 'comment-or-uncomment-region
+        "nci" 'evilnc-toggle-invert-comment-line-by-line
+        "ncc" 'evilnc-comment-operator))))
+
 (defun spacemacs/init-evil-org-mode ()
   (use-package evil-org
     :commands evil-org-mode

spacemacs/packages.el

@@ -34,7 +34,6 @@
     evil-surround
     evil-terminal-cursor-changer
     evil-visualstar
-    evil-nerd-commenter
     exec-path-from-shell
     expand-region
     fill-column-indicator
@@ -364,20 +363,6 @@ DELETE-FUNC when calling CALLBACK.
       ;; load surround
       (use-package evil-surround
         :init (global-evil-surround-mode 1))
-      ;; load nerd-commenter
-      (if (version< emacs-version "24.4")
-          (use-package evil-nerd-commenter
-            :init
-            (progn
-              (evil-leader/set-key
-                "ncl" 'evilnc-comment-or-uncomment-lines
-                "nct" 'evilnc-quick-comment-or-uncomment-to-the-line
-                "ncy" 'evilnc-copy-and-comment-lines
-                "ncp" 'evilnc-comment-or-uncomment-paragraphs
-                "ncr" 'comment-or-uncomment-region
-                "nci" 'evilnc-toggle-invert-comment-line-by-line
-                "ncc" 'evilnc-comment-operator
-                ))))
       ;; load evil-exchange
       (use-package evil-exchange
         :init (evil-exchange-install))