Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated configs for lsp-javascript-typescript? #11845

Closed
yuhan0 opened this issue Jan 14, 2019 · 2 comments
Closed

Outdated configs for lsp-javascript-typescript? #11845

yuhan0 opened this issue Jan 14, 2019 · 2 comments

Comments

@yuhan0
Copy link
Contributor

yuhan0 commented Jan 14, 2019

The package lsp-javascript-typescript was added in commit cffd900
and later removed in commit f346ae0

However, some remnants from the first commit are still around:

  • A reference in javascript/REAME.org
  • the post-init functions
    • typescript/post-init-lsp-javascript-typescript
    • react/post-init-lsp-javascript-typescript
  • call to (lsp-javascript-typescript-enable) in
    • spacemacs//react-setup-lsp
    • spacemacs//typescript-setup-lsp

I don't use React/ Typescript and don't know enough about LSP to submit a fix for this, but it seems like these changes should be reverted or that the package should be owned by an init function in either of the layers.

@yuhan0 yuhan0 changed the title Outdated and unused configs for lsp-javascript-typescript Outdated configs for lsp-javascript-typescript? Jan 14, 2019
@jamartin9
Copy link

jamartin9 commented Jan 14, 2019

@yuhan0

This is mostly ripple/leftovers from lsp-mode having a major update recently.

My PR that was merged: #11765 addresses most of your issues (+some):

  1. both post-init(s) removed
  2. both setup-lsp functions updated to new lsp entrypoint

The javascript/README.org does not appear to be out of date yet as it matches the lsp-mode instructions atm.

If anything wasn't addressed in that pull request please lmk and so they can get fixed.

refs: #11761

@sdwolfz sdwolfz added this to the Release 0.300 milestone Jan 14, 2019
@yuhan0
Copy link
Contributor Author

yuhan0 commented Jan 14, 2019

Thanks for the reply! I noticed these "leftovers" while helping with the changelog and didn't realise there was a pending PR to fix them.
The merged changes look alright as far as I can tell, so this issue can be closed :)

@yuhan0 yuhan0 closed this as completed Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants