Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rev 24d875e break keyboard-layout #11954

Closed
CharlesHD opened this issue Feb 8, 2019 · 9 comments
Closed

rev 24d875e break keyboard-layout #11954

CharlesHD opened this issue Feb 8, 2019 · 9 comments
Labels
- Bug tracker - Fixed in develop Keyboard layouts stale marked as a stale issue/pr (usually by a bot)

Comments

@CharlesHD
Copy link
Contributor

CharlesHD commented Feb 8, 2019

Description :octocat:

New changes (probably commit 24d875e ) break keyboard-layout compatibility and yield

Warning (initialization): An error occurred while loading ‘/home/charleshd/.emacs.d/init.el’:

error: Key sequence w c c starts with non-prefix key w c

EDIT: This is true for bepo configuration. But not for Dvorak. I suspect this is a wild rebinding of wc somewhere inside the keyboard-layout machinery.

Reproduction guide 🪲

  • Ensure you have the keyboard-layout layer
  • Start Emacs

Observed behaviour: 👀 💔
Initialization error

Expected behaviour: ❤️ 😄
No error

System Info 💻

  • OS: gnu/linux
  • Emacs: 26.1
  • Spacemacs: 0.300.0
  • Spacemacs branch: usage (rev. 69f6355)
  • Graphic display: t
  • Distribution: spacemacs
  • Editing style: vim
  • Completion: helm
  • Layers:
((keyboard-layout :variables kl-layout 'bepo))
  • System configuration features: XPM JPEG TIFF GIF PNG RSVG SOUND DBUS GSETTINGS NOTIFY LIBSELINUX GNUTLS LIBXML2 FREETYPE XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 MODULES THREADS
@gh-salt
Copy link

gh-salt commented Feb 10, 2019

I have the same issue (I was about to post an issue when I found this thread). I also use the bepo layer.

System Info 💻

  • OS: gnu/linux
  • Emacs: 25.1.1
  • Spacemacs: 0.300.0
  • Spacemacs branch: develop (rev. 3dd7539)
  • Graphic display: t
  • Distribution: spacemacs
  • Editing style: vim
  • Completion: helm
((keyboard-layout :variables kl-layout 'bepo))
  • System configuration features: XAW3D XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS NOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS LUCID X11

@CharlesHD
Copy link
Contributor Author

CharlesHD commented Feb 19, 2019

For the moment my quick dirty fix is to comment those lines in
layers/+spacemacs/spacemacs-defaults/keybindings.el :

  ;; "wcc"  'spacemacs/toggle-centered-buffer
  ;; "wcC"  'spacemacs/toggle-distraction-free
  ;; "wc."  'spacemacs/centered-buffer-transient-state

EDIT:
Finally, I pinned down the problem to evil-window rebinding.
In layers/+intl/keyboard-layout/packages.el you can comment those lines, they do not work for the moment according to the FIXME, so this is not harmful. Still, it is not a bug fixed till' these lines does not work.

  (kl|config evil-window
    :description
    "Remap `evil-window' bindings."
    :loader
    (with-eval-after-load 'evil-commands BODY)
    ;; :common
    ;; ;; FIXME: Not working
    ;; (kl/leader-correct-keys
    ;;   "wh"
    ;;   "wj"
    ;;   "wk"
    ;;   "wl"
    ;;   ;;
    ;;   "wH"
    ;;   "wJ"
    ;;   "wK"
    ;;   "wL")
    :bepo
    (progn
      (spacemacs/set-leader-keys
        "" 'other-window
        "wq" 'delete-window)
      (kl/leader-alias-of "é" "w"))))

@bepolymathe
Copy link

Thank you for this correction which allowed me to solve this problem temporarily. Solutions have since been found?

@CharlesHD
Copy link
Contributor Author

I was planning to do a PR about this (just line commenting). Then an exploratory work to get evil-window working. But I forgot. Thanks for the reminder. I'll take a look when i'm in front of a keyboard.

@PiOverFour
Copy link
Contributor

@CharlesHD Hi, I have the same error. Are you still working on the issue?

CharlesHD added a commit to CharlesHD/spacemacs that referenced this issue Jan 6, 2020
duianto pushed a commit that referenced this issue Jan 13, 2020
Commented out broken evil-window :common bindings.

#11954
@duianto
Copy link
Collaborator

duianto commented Jan 13, 2020

The following PRs changes have been applied to the develop branch:
Keyboard-Layout : Quick Fix of issue #11954 #13159

@bepolymathe
Copy link

Thank you for this information @duianto . So we can remove these changes without fear? Or will the next update correct this?

@duianto
Copy link
Collaborator

duianto commented Jan 13, 2020

If your using the develop branch (it's the suggested branch until the next master branch release (I don't have any insight into when that is)) then you can remove your local changes to fix this issue.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please let us know if this issue is still valid!

@github-actions github-actions bot added the stale marked as a stale issue/pr (usually by a bot) label Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
- Bug tracker - Fixed in develop Keyboard layouts stale marked as a stale issue/pr (usually by a bot)
Projects
None yet
Development

No branches or pull requests

5 participants