Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New binding for magit-file-dispatch is confusingly different from magit-dispatch binding #14434

Closed
ilyagr opened this issue Feb 27, 2021 · 2 comments · Fixed by #14436
Closed

Comments

@ilyagr
Copy link
Contributor

ilyagr commented Feb 27, 2021

Recent commit e3434e8 switched the <SPC> g f d binding to mean magit-file-dispatch instead of magit-file-diff. I'm very happy to have a binding for magit-file-dispatch. However, now there is a confusing mismatch: <SPC> g f d means magit-file-dispatch, and <SPC> g m means magit-dispatch. I think one of the following two things should happen:

a) <SPC> g f m should mean magit-file-dispatch and <SPC> g f d should be restored to mean magit-file-diff. I'd prefer this, since magit-file-diff is useful.

b) The binding to magit-dispatch should change to <SPC> g d.

If either of these options look OK, I'm happy to implement it.

@ilyagr
Copy link
Contributor Author

ilyagr commented Feb 27, 2021

See also #14408 for background. I don't think anyone noticed the mismatch.

@lebensterben
Copy link
Collaborator

I prefer the first solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants