modline/spaceline clobbered during git commit with magit #14726

jsilve24 · 2021-04-29T12:59:25Z

Description

First off, thank you for all your help building spacemacs, its awesome.

This is an expansion on the brief notes I left on closed issue #176 (TheBB/spaceline#176)

In short, whenever I enter the commit menu using magit (SPC g s and then c c) my spaceline/modline gets clobbered and does not return until I restart spacemacs.

Screenshot before

** Screenshot during commit (note same modline appearance is seen until spacemacs restarts)**

My .spacemacs (renamed to spacemacs.txt so I can upload to github)
spacemacs.txt

Reproduction guide 🪲

Start Emacs using my .spacemacs as it seems at least some other users are not having this trouble
SPC g s
c c
Get frustrated as modline disappears

Observed behaviour: 👀 💔
spaceline replaced by empty bordered "cells"

Expected behaviour: ❤️ 😄
spaceline not clobbered :)

System Info 💻

OS: gnu/linux
Emacs: 26.3
Spacemacs: 0.300.0
Spacemacs branch: develop (rev. df15f8c)
Graphic display: t
Distribution: spacemacs
Editing style: vim
Completion: helm
Layers:

(python csv auto-completion emacs-lisp git helm
        (deft :variables deft-zetteldeft t)
        (markdown :variables markdown-command "pandoc")
        multiple-cursors org spell-checking syntax-checking
        (ranger :variables ranger-override-dired 'ranger ranger-show-preview t)
        treemacs latex bibtex ess polymode imenu-list
        (evil-snipe :variables evil-snipe-enable-alternate-f-and-t-behaviors t))

System configuration features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GSETTINGS GLIB NOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM THREADS LIBSYSTEMD LCMS2

Backtrace 🐾

<<BACKTRACE IF RELEVANT>>

The text was updated successfully, but these errors were encountered:

lebensterben · 2021-04-30T05:43:32Z

This is an upstream bug of spaceline.
I use doom-modeline and there's no such issue.

hhkgrz · 2021-05-09T05:00:19Z

Same problem here, it seems this issue is caused by commits 4836a25 and 38f582d.

At

spacemacs/layers/+spacemacs/spacemacs-visual/packages.el

Line 68 in 38f582d

:spacediminish ((fci-mode " ⓕ" " f"))

, change ':spacediminish ((fci-mode " ⓕ" " f"))' to ':spacediminish (fci-mode " ⓕ" " f")' could make it work.

But not sure if this is an appropriate way to fix this.

Need the experts' help on this.

lebensterben · 2021-05-09T05:59:26Z

I will take a look.

lebensterben · 2021-05-28T02:10:45Z

@hhkgrz
Can you verify whether it's fixed now?

mbertheau · 2021-05-30T06:46:29Z

I still get this:

Error during redisplay: (eval (spaceline-ml-main)) signaled (wrong-type-argument symbolp (fci-mode " ⓕ" " f"))

The code changed here wants to distinguish the cases of whether `arg` is a list with one set of args to `spacemacs|diminish` or a list of a list of such args. It used to look at the second element of `args` to make that distinction. Consequently, if you want to specify a list of a list of args for `:spacediminish`, you'd have to have at least two such lists of args in the list. However in syl20bnr@38f582d a usage with a list of just one list of args was introduced. This fixes changes the detection so that it looks at the first element of `arg`. If that's a list, `arg` is assumed to be a list of lists of args to `spacemacs|diminish`. If it's not, it's assumed to be just a list of args to `spacemacs|diminish`. That works well because the first argument to `spacemacs|diminish` is a symbol. Fixes syl20bnr#14726

mbertheau · 2021-05-30T08:19:59Z

I'm getting the following backtrace

Tracing a bit through the code, the problem seems to be in here

(defun use-package-handler/:spacediminish (name _keyword arg rest state)
  (debug)
  (let ((body (use-package-process-keywords name rest state)))
    (use-package-concat
     `((when (fboundp 'spacemacs|diminish)
         ,@(if (consp (cadr arg)) ;; e.g. ((MODE1 FOO BAR) (MODE2 BAZ XYZ))
               (mapcar #'(lambda (var) `(spacemacs|diminish ,@var))
                       arg)
             `((spacemacs|diminish ,@arg))))) ;; e.g. (MODE FOO BAR)
     body)))

at (cadr arg) arg is ((fci-mode "..." "...")), so the cadr evals to nil and consequently the other branch of the if is taken.

Thus, in the current implementation, :spacediminish supports a "list of patterns above" (see 4836a25) only if that list has at least two elements in it.

A proposed fix is in #14810.

The code changed here wants to distinguish the cases of whether `arg` is a list with one set of args to `spacemacs|diminish` or a list of a list of such args. It used to look at the second element of `args` to make that distinction. Consequently, if you want to specify a list of a list of args for `:spacediminish`, you'd have to have at least two such lists of args in the list. However in syl20bnr@38f582d a usage with a list of just one list of args was introduced. This fixes changes the detection so that it looks at the first element of `arg`. If that's a list, `arg` is assumed to be a list of lists of args to `spacemacs|diminish`. If it's not, it's assumed to be just a list of args to `spacemacs|diminish`. That works well because the first argument to `spacemacs|diminish` is a symbol. Fixes syl20bnr#14726

The code changed here wants to distinguish the cases of whether `arg` is a list with one set of args to `spacemacs|diminish` or a list of a list of such args. It used to look at the second element of `args` to make that distinction. Consequently, if you want to specify a list of a list of args for `:spacediminish`, you'd have to have at least two such lists of args in the list. However in 38f582d a usage with a list of just one list of args was introduced. This fixes changes the detection so that it looks at the first element of `arg`. If that's a list, `arg` is assumed to be a list of lists of args to `spacemacs|diminish`. If it's not, it's assumed to be just a list of args to `spacemacs|diminish`. That works well because the first argument to `spacemacs|diminish` is a symbol. Fixes #14726

lebensterben · 2021-05-31T04:39:45Z

Should be fixed in #14810

fixes syl20bnr#14726

The code changed here wants to distinguish the cases of whether `arg` is a list with one set of args to `spacemacs|diminish` or a list of a list of such args. It used to look at the second element of `args` to make that distinction. Consequently, if you want to specify a list of a list of args for `:spacediminish`, you'd have to have at least two such lists of args in the list. However in syl20bnr@38f582d a usage with a list of just one list of args was introduced. This fixes changes the detection so that it looks at the first element of `arg`. If that's a list, `arg` is assumed to be a list of lists of args to `spacemacs|diminish`. If it's not, it's assumed to be just a list of args to `spacemacs|diminish`. That works well because the first argument to `spacemacs|diminish` is a symbol. Fixes syl20bnr#14726

lebensterben closed this as completed Apr 30, 2021

lebensterben added the Reported upstream label Apr 30, 2021

lebensterben reopened this Apr 30, 2021

lebensterben added Should report upstream and removed Reported upstream Should report upstream labels May 9, 2021

lebensterben self-assigned this May 9, 2021

mbertheau added a commit to mbertheau/spacemacs that referenced this issue May 22, 2021

Workaround syl20bnr#14726

78e7b01

mbertheau added a commit to mbertheau/spacemacs that referenced this issue May 26, 2021

Workaround syl20bnr#14726

315f12f

mbertheau added a commit to mbertheau/spacemacs that referenced this issue May 26, 2021

Workaround syl20bnr#14726

9771051

mbertheau added a commit to mbertheau/spacemacs that referenced this issue May 27, 2021

Workaround syl20bnr#14726

b2fa170

mbertheau added a commit to mbertheau/spacemacs that referenced this issue May 27, 2021

Workaround syl20bnr#14726

9d0975b

mbertheau added a commit to mbertheau/spacemacs that referenced this issue May 27, 2021

Workaround syl20bnr#14726

2596f67

mbertheau added a commit to mbertheau/spacemacs that referenced this issue May 27, 2021

Workaround syl20bnr#14726

e79caa0

mbertheau added a commit to mbertheau/spacemacs that referenced this issue May 27, 2021

Workaround syl20bnr#14726

6e80cb0

lebensterben mentioned this issue May 28, 2021

Modeline is clobbered when fill-column is enabled #14801

Closed

lebensterben closed this as completed in d9132f8 May 28, 2021

mbertheau mentioned this issue May 30, 2021

Fix one diminish pattern in a list in :spacediminish #14810

Merged

lebensterben reopened this May 30, 2021

lebensterben closed this as completed in #14810 May 31, 2021

wang-d pushed a commit to wang-d/spacemacs that referenced this issue Jul 22, 2021

spacedminish: fixed bug

b2def63

fixes syl20bnr#14726

lebensterben added the Fixed in develop label Feb 9, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

modline/spaceline clobbered during git commit with magit #14726

modline/spaceline clobbered during git commit with magit #14726

jsilve24 commented Apr 29, 2021

lebensterben commented Apr 30, 2021

hhkgrz commented May 9, 2021

lebensterben commented May 9, 2021

lebensterben commented May 28, 2021

mbertheau commented May 30, 2021

mbertheau commented May 30, 2021

lebensterben commented May 31, 2021

modline/spaceline clobbered during git commit with magit #14726

modline/spaceline clobbered during git commit with magit #14726

Comments

jsilve24 commented Apr 29, 2021

Description

Reproduction guide 🪲

System Info 💻

Backtrace 🐾

lebensterben commented Apr 30, 2021

hhkgrz commented May 9, 2021

lebensterben commented May 9, 2021

lebensterben commented May 28, 2021

mbertheau commented May 30, 2021

mbertheau commented May 30, 2021

lebensterben commented May 31, 2021