Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small improvements to core-load-paths.el #16355

Merged
merged 3 commits into from
May 11, 2024
Merged

Small improvements to core-load-paths.el #16355

merged 3 commits into from
May 11, 2024

Conversation

bcc32
Copy link
Contributor

@bcc32 bcc32 commented Apr 4, 2024

No description provided.

@bcc32
core-load-paths.el: Ensure spacemacs-cache-directory is in start dir
b5134d9 
If the user installs Spacemacs to a different directory, the cache
should be located there.
@bcc32
core-load-paths.el: Simplify making cache directory
e9fb3dd 
With PARENTS, make-directory will not error if the directory already
exists.
@bcc32
core-load-paths.el: Simplify redundant ../ in spacemacs-start-directory
7f6a15b
@smile13241324 smile13241324 merged commit 1f9a70b into syl20bnr:develop May 11, 2024
8 checks passed
@bcc32 bcc32 deleted the simplify-load-paths branch May 14, 2024 04:07
@sunlin7
Copy link
Contributor

sunlin7 commented May 20, 2024

Hi @bcc32
Why change the .cache folder from ~/.emacs.d/ to the spacemacs installation folder?
https://github.com/syl20bnr/spacemacs/pull/16355/files#diff-2ed2a13c6fbd6262b08ee51062ff34063a31838546235aea0a1dceebd81a1a3aL98

@bcc32
Copy link
Contributor Author

bcc32 commented May 20, 2024

Most of the time ~/.emacs.d/ is in fact the spacemacs installation directory. But, if a user installs spacemacs to a different directory, Spacemacs's state should live there. It's also consistent with all the other spacemacs-*- directory definitions in that file. Is there a case where you think this is the wrong behavior?

@sunlin7
Copy link
Contributor

sunlin7 commented May 20, 2024

Hi @bcc32
I deployed the Spacemacs in a readonly (shared) path, and the .cache should be a per user settings.

@bcc32
Copy link
Contributor Author

bcc32 commented May 21, 2024

Aha, that's a great point. Submitted #16409 to revert that particular change and add an explanatory comment. Thanks for pointing this out, @sunlin7 .

@sunlin7
Copy link
Contributor

sunlin7 commented May 21, 2024

Thank you more !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smile13241324 smile13241324 smile13241324 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bcc32 @sunlin7 @smile13241324