spacemacs|dimish does not work when spaceline is excluded

[sooheon]

Description

Calls to spacemacs|diminish when spaceline is excluded from dotspacemacs is ineffectual. Is there some unnecessary coupling there?

Reproduction guide

• Add spaceline to dotspacemacs-excluded-packages
• Set dotspacemacs-mode-line-unicode-symbols nil
• Restart Emacs
• Observe non-diminished modeline
• Interactively (or in code) call something like (spacemacs|diminish evil-cleverparens-mode nil " cp")

Observed behaviour:
No diminishing!

Expected behaviour:
Diminishing according to given string.

System Info

• OS: darwin
• Emacs: 24.5.1
• Spacemacs: 0.105.11
• Spacemacs branch: develop (rev. fd93264)
• Distribution: spacemacs
• Editing style: hybrid
• Completion: ivy
• Layers:

((auto-completion :variables auto-completion-tab-key-behavior 'cycle auto-completion-return-key-behavior 'complete auto-completion-enable-snippets-in-popup t auto-completion-enable-sort-by-usage t)
 better-defaults colors clojure dash emacs-lisp
 (evil-snipe :variables evil-snipe-enable-alternate-f-and-t-behaviors t)
 finance html markdown
 (shell :variables shell-default-position 'bottom shell-default-shell 'eshell)
 git org osx pandoc rcirc syntax-checking spacemacs-ivy version-control
 (vinegar :variables vinegar-reuse-dired-buffer t)
 sooheon)

[TheBB]

Yes, this doesn't work if spaceline is not enabled.

[person808]

Seems like the function spacemacs//prepare-diminish is responsible

[justbur]

I just ran into this. Here's a workaround

  (defun spacemacs/diminish-hook (_)
    (cl-loop for (mode uni nouni) in spacemacs--diminished-minor-modes
             do
             (diminish mode
                       (if dotspacemacs-mode-line-unicode-symbols
                           uni nouni))))
  (add-hook 'after-load-functions 'spacemacs/diminish-hook)

[TheBB]

Seems like a reasonable thing to put in spacemacs-base/init-diminish if Spaceline is not present.

[d12frosted]

Fixed with released of Spacemacs v0.200. Let us know if you still have any problems with this issue.

[lebensterben]

Currently, spacemacs|diminish has no effects when spaceline is enabled...
which is opposite to the original issue...

If we choose doom-modeline as the modeline theme, it installs doom-modeline package but doesn't disable spaceline, therefore

spacemacs/layers/+distributions/spacemacs-bootstrap/packages.el

Lines 55 to 56 in 95280d1

	(unless (configuration-layer/package-used-p 'spaceline)
	(add-hook 'after-load-functions 'spacemacs/diminish-hook)))

never evaluates.

[github-actions]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please let us know if this issue is still valid!