Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

evilification breaks anaconda-view-mode #5737

Closed
mineo opened this issue Apr 9, 2016 · 2 comments
Closed

evilification breaks anaconda-view-mode #5737

mineo opened this issue Apr 9, 2016 · 2 comments
Labels
- Bug tracker - Fixed in develop Key Bindings Ready for work stale marked as a stale issue/pr (usually by a bot)

Comments

@mineo
Copy link
Contributor

mineo commented Apr 9, 2016

Description

The function that's bound to n in anaconda-view-mode (next-error-no-select) does not get rebound to any key.

Reproduction guide

  • Start Emacs
  • Open a python file
  • Move cursor to a function definition
  • , g u on the function name
  • move to the new buffer
  • press n

Observed behaviour:

  • n tries to repeat the last search

Expected behaviour:

  • Cursor moves to the next entry

System Info

  • OS: gnu/linux
  • Emacs: 24.5.1
  • Spacemacs: 0.105.14
  • Spacemacs branch: master (rev. a298a5a)
  • Graphic display: t
  • Distribution: spacemacs
  • Editing style: vim
  • Completion: helm
  • Layers:
((auto-completion :variables auto-completion-enable-help-tooltip t)
 (c-c  )
 emacs-lisp git github jabber
 (haskell :variables haskell-enable-ghc-mod-support t)
 html
 (latex :variables latex-build-command "LatexMk")
 markdown mineo mineo-rtags org python scala
 (shell :variables shell-default-position 'bottom shell-default-term-shell "/bin/zsh")
 (syntax-checking :variables syntax-checking-enable-tooltips nil)
 version-control)
@mineo
Copy link
Contributor Author

mineo commented Apr 9, 2016

According to the rules linked to in #5738, next-error-no-select should be bound to C-n in evilified state, but it's not.

mineo added a commit to mineo/spacemacs that referenced this issue Oct 24, 2016
@mineo
Map {j,k} to {next,previous}-error-no-select in anaconda-mode-view-mode
f8a018a 
This is similar to the mappings done for flycheck-error-list-mode-map
and works around the broken evilification in
anaconda-mode-view-mode (see syl20bnr#5737).
@mineo mineo mentioned this issue Oct 24, 2016
Closed
@jredville jredville mentioned this issue Oct 26, 2016
Closed
nixmaniack added a commit to nixmaniack/spacemacs that referenced this issue Nov 28, 2016
@nixmaniack
python: fixes for anaconda-mode-view-mode
1afe3f6 
* layers/+lang/python/funcs.el (spacemacs/anaconda-view-forward-and-push):
  Added helper function to go forward and hit RET
* layers/+lang/python/packages.el (python/init-anaconda-mode):
   - use new evilification macro
   - use helper function to go ahead and push button when hitting `RET`
   - Add `C-j`, `C-k` for easy navigation in anaconda-view-mode when multiple
   references are displayed. Doesn't conflict with normal `hjkl` navigation in
   other views of `anaconda-view-mode`

Fix syl20bnr#7538
Fix syl20bnr#5737
@nixmaniack nixmaniack mentioned this issue Nov 28, 2016
Closed
TheBB pushed a commit that referenced this issue May 24, 2017
@nixmaniack @TheBB
python: fixes for anaconda-mode-view-mode
47cb3e0 
* layers/+lang/python/funcs.el (spacemacs/anaconda-view-forward-and-push):
  Added helper function to go forward and hit RET
* layers/+lang/python/packages.el (python/init-anaconda-mode):
   - use new evilification macro
   - use helper function to go ahead and push button when hitting `RET`
   - Add `C-j`, `C-k` for easy navigation in anaconda-view-mode when multiple
   references are displayed. Doesn't conflict with normal `hjkl` navigation in
   other views of `anaconda-view-mode`

Fix #7538
Fix #5737
CodingSolo pushed a commit to CodingSolo/spacemacs that referenced this issue Oct 29, 2018
@nixmaniack
python: fixes for anaconda-mode-view-mode
2f5376d 
* layers/+lang/python/funcs.el (spacemacs/anaconda-view-forward-and-push):
  Added helper function to go forward and hit RET
* layers/+lang/python/packages.el (python/init-anaconda-mode):
   - use new evilification macro
   - use helper function to go ahead and push button when hitting `RET`
   - Add `C-j`, `C-k` for easy navigation in anaconda-view-mode when multiple
   references are displayed. Doesn't conflict with normal `hjkl` navigation in
   other views of `anaconda-view-mode`

Fix syl20bnr#7538
Fix syl20bnr#5737
@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please let us know if this issue is still valid!

@github-actions github-actions bot added the stale marked as a stale issue/pr (usually by a bot) label Feb 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
- Bug tracker - Fixed in develop Key Bindings Ready for work stale marked as a stale issue/pr (usually by a bot)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@mineo @TheBB @syl20bnr @StreakyCobra @d12frosted