dotspacemacs-install-packages 'all broken

[JAremko]

When run Spacemacs with dotspacemacs-install-packages 'all the function spacemacs/toggle-line-numbers-off is undefined. Using dotspacemacs-install-packages 'used-but-keep-unused works fine.

@syl20bnr If it's a bug I think it need to be fixed before release 😕

[syl20bnr]

I cannot reproduce it, is this bug still valid. If yes, what's the repro steps ?

[JAremko]

@syl20bnr

1. use this as .spacemacs or simply set dotspacemacs-install-packages 'all
2. SPC h SPC and open random file.

if: Symbol's function definition is void: spacemacs/toggle-line-numbers-off

[JAremko]

Also it may require Spacemacs installation from that .spacmeacs

Or something like:

git clone https://github.com/syl20bnr/spacemacs.git -b develop ~/.emacs.d
cp ~/.emacs.d/core/templates/.spacemacs.template ~/
mv ~/.spacemacs.template ~/.spacemacs 
sed -i "s/dotspacemacs-install-packages 'used-only/dotspacemacs-install-packages 'all/"  ~/.spacemacs
emacs -nw -batch -u USER -kill 
# With this step it will work fine:
# sed -i "s/dotspacemacs-install-packages 'all/dotspacemacs-install-packages 'used-but-keep-unused/" ~/.spacemacs
emacs

Emacs 24.5.1

[JAremko]

@syl20bnr nuked my Spacemacs (absolutely) and used that ^^^^^ bash snippet. Started emacs - got a bunch of errors + the bug. Then executed sed -i "s/dotspacemacs-install-packages 'all/dotspacemacs-install-packages 'used-but-keep-unused/" ~/.spacemacs and started emacs - all is ok.

[syl20bnr]

Thanks, I'm looking into it.

[syl20bnr]

Fixed in 0.200.1

[JAremko]

@syl20bnr Awesome! ❤️

[ksjogo]

This patch breaks :excluded entries in dotspacemacs-additional-packages in dotfile. 'dotfile is not in configuration-layer--used-layers, thus the exclude won't be taken.

[zilongshanren]

@ksjogo
Before apply this patch, it seems there is no method to install a package which is excluded in a layer.

Now I could add the excluded package name in the dotspacemacs-additional-packages which seems good for me.

[syl20bnr]

@ksjogo thanks for the report, I don't think this is a bug there is a dotfile variable for this purpose: dotspacemacs-excluded-packages.

But I can add a warning to explicitly say that :excluded is ignored and that a user should to use dotspacemacs-excluded-packages variable instead.

@zilongshanren nice! Definitely need to add a test case to document this property.

[ksjogo]

I was qqing some excluded values, so I only needed them in one place, will look into moving to excluded packages.
Anyway, why is the dotfile layer not seens as used layer?

[syl20bnr]

@ksjogo this is a good question :-) I have not the answer right now, I need to think about it and the implication (right now the dotfile can own a package config but it is not a really a layer).