Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't use org-edit-special in org-mode with plantuml (puml-mode) #7298

Closed
EMayej opened this issue Oct 6, 2016 · 1 comment
Closed

Can't use org-edit-special in org-mode with plantuml (puml-mode) #7298

EMayej opened this issue Oct 6, 2016 · 1 comment

Comments

@EMayej
Copy link
Contributor

EMayej commented Oct 6, 2016

Description :octocat:

Can't use org-edit-specil with plantuml

Reproduction guide 🪲

  • Start Emacs
  • Open test.org
  • Type in below text
# BEGIN_SRC plantuml :file x.svg
  Alice -> Bob : Hello
# END_SRC
  • SPC m ' (which calls org-edit-special)

Observed behaviour: 👀 💔
emacs reports no plantuml-mode

Expected behaviour: ❤️ 😄
a new window opens with puml-mode

Possible solution:
https://github.com/skuro/puml-mode#integration-with-org-mode

System Info 💻

  • OS: darwin
  • Emacs: 25.1.1
  • Spacemacs: 0.105.22
  • Spacemacs branch: develop (rev. cf951a5)
  • Graphic display: t
  • Distribution: spacemacs
  • Editing style: vim
  • Completion: ivy
  • Layers:
(ivy
 (auto-completion :variables auto-completion-enable-snippets-in-popup t)
 clojure semantic dash emacs-lisp fasd git plantuml graphviz org osx ranger shell-scripts
 (python :variables python-test-runner 'pytest)
 (shell :variables shell-default-shell 'eshell shell-default-height 30 shell-default-position 'bottom)
 spell-checking syntax-checking)
@Mitchicus
Copy link

Yes, and also for this layer it could be handy to document that you may need to set puml-plantuml-jar-path. I got tripped up on this when the layer was added and replaced my own config.

I'll make a PR briefly to fix this issue

Mitchicus added a commit to Mitchicus/spacemacs that referenced this issue Oct 10, 2016
- Replace plantuml/post-init-org with a pre-init-org hook to properly
load the configuration.
- Associate plantuml with its major mode for org src buffers/blocks

Fixes: syl20bnr#7298
@EMayej EMayej closed this as completed Oct 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants