Uncouple version from banner in spacemacs buffer #11901
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The banner can be hidden by changing: to in |
The line in the Spacemacs home buffer that shows the Spacemacs version, Emacs version and the Spacemacs distribution, for example: "0.300.0@26.1 (spacemacs)" were tied to the banner. The line disappeared when the banner was hidden.
duianto
force-pushed
the
uncouple-version-from-banner
branch
from
cd8acdc
to
6c24de8
Compare
|
Thank you for contributing to Spacemacs! |
duianto
added a commit
to duianto/spacemacs
that referenced
this pull request
Nov 29, 2019
Removed the first line deletion. This required the banners to have an empty first line. Removed the empty first line from the banners. Made sure that there is a single empty line between: - The version and Banner. - Banner and Buttons ([?] [Homepage] ...). - Version and Buttons (when the banner is hidden). These changes also reordered the version insertion function to match the backend call order, with the order they are shown in the spacemacs home buffer: version banner buttons Before this change it added: - the banner - the buffers first line was removed - the version was added to the first line - then the buttons were added (there are more things added after the buttons, but they haven't been changed by this commit). Removed the version insertion in: core/core-spacemacs-buffer.el The changes above made that insert the version twice into the home buffer on startup. I'm not sure if it has/had other uses. This seems to be where it was first added to: core-configuration-layer.el: core: restore default mode line in home buffer syl20bnr@77161bd It was slightly modified in this commit: core: defer distro insertion in home buffer syl20bnr@cd50d9c Here it was joined with the banner: Fix version injection in home buffer Don't inject version if banner is nil syl20bnr@a764eb4 core: condensed versions into one string in left-hand side spacemacs-version@emacs-version (distribution) syl20bnr@627e934 I had not seen that the version was joined with the banner on purpose until now. Therefore it seemed useful to still be able to see the versions if one just wanted to hide the banner. I opened this PR (it's been cherry-picked): Uncouple version from banner in spacemacs buffer syl20bnr#11901 syl20bnr#11901 If there's a good reason to combine them again, then the changes can be reverted.
duianto
added a commit
to duianto/spacemacs
that referenced
this pull request
Nov 29, 2019
Removed the first line deletion. This required the banners to have an empty first line. Removed the empty first line from the banners. Made sure that there is a single empty line between: - The version and Banner. - Banner and Buttons ([?] [Homepage] ...). - Version and Buttons (when the banner is hidden). These changes also reordered the version insertion function to match the backend call order, with the order they are shown in the spacemacs home buffer: version banner buttons Before this change it added: - the banner - the buffers first line was removed - the version was added to the first line - then the buttons were added (there are more things added after the buttons, but they haven't been changed by this commit). Removed the version insertion in: core/core-spacemacs-buffer.el The changes above made that insert the version twice into the home buffer on startup. I'm not sure if it has/had other uses. This seems to be where it was first added to: core-configuration-layer.el: core: restore default mode line in home buffer syl20bnr@77161bd It was slightly modified in this commit: core: defer distro insertion in home buffer syl20bnr@cd50d9c Here it was joined with the banner: Fix version injection in home buffer Don't inject version if banner is nil syl20bnr@a764eb4 core: condensed versions into one string in left-hand side spacemacs-version@emacs-version (distribution) syl20bnr@627e934 I had not seen that the version was joined with the banner on purpose until now. Therefore it seemed useful to still be able to see the versions if one just wanted to hide the banner. I opened this PR (it's been cherry-picked): Uncouple version from banner in spacemacs buffer syl20bnr#11901 syl20bnr#11901 If there's a good reason to combine them again, then the changes can be reverted.
duianto
added a commit
to duianto/spacemacs
that referenced
this pull request
Nov 29, 2019
- Removed the first line deletion. This required the banners to have an empty first line. - Removed the empty first line from the banners. - Made sure that there is a single empty line between: - The version and Banner. - Banner and Buttons ([?] [Homepage] ...). - Version and Buttons (when the banner is hidden). - Reordered the backend version insertion function call to match the frontend Spacemacs buffer order. - version - banner - buttons Before it added: - the banner - then the buffers first line was removed - then the version was added to the first line - then the buttons were added at the bottom of the buffer (there are more things added after the buttons, but they haven't been changed by this commit). - Removed the version insertion call in: core/core-spacemacs-buffer.el The changes above caused the version to appear twice in the Spacemacs home buffer on startup. I'm not sure if it has/had other uses. This seems to be where it was first added to: core-configuration-layer.el: core: restore default mode line in home buffer syl20bnr@77161bd It was slightly modified in this commit: core: defer distro insertion in home buffer syl20bnr@cd50d9c Here it was joined with the banner: Fix version injection in home buffer Don't inject version if banner is nil syl20bnr@a764eb4 core: condensed versions into one string in left-hand side spacemacs-version@emacs-version (distribution) syl20bnr@627e934 - I had not seen that the version was joined with the banner on purpose until now. It seemed useful to still be able to see the versions if one just wanted to hide the banner. Therefore I opened this PR (it's been cherry-picked): Uncouple version from banner in spacemacs buffer syl20bnr#11901 syl20bnr#11901 If there's a good reason to combine them again, then the changes can be reverted.
duianto
added a commit
to duianto/spacemacs
that referenced
this pull request
Nov 29, 2019
- Removed the first line deletion. This required the banners to have an empty first line. - Removed the empty first line from the banners. - Made sure that there is a single empty line between: - The Version and Banner. - Banner and Buttons ([?] [Homepage] ...). - Version and Buttons (when the banner is hidden). - Reordered the backend version insertion function call to match the frontend Spacemacs buffer order. - version - banner - buttons Before it added: - the banner - then the buffers first line was removed - then the version was added to the first line - then the buttons were added at the bottom of the buffer (there are more things added after the buttons, but they haven't been changed by this commit). - Removed the version insertion call in: core/core-spacemacs-buffer.el The changes above caused the version to appear twice in the Spacemacs home buffer on startup. I'm not sure if it has/had other uses. This seems to be where it was first added to: core-configuration-layer.el: core: restore default mode line in home buffer syl20bnr@77161bd It was slightly modified in this commit: core: defer distro insertion in home buffer syl20bnr@cd50d9c Here it was joined with the banner: Fix version injection in home buffer Don't inject version if banner is nil syl20bnr@a764eb4 core: condensed versions into one string in left-hand side spacemacs-version@emacs-version (distribution) syl20bnr@627e934 - I had not seen that the version was joined with the banner on purpose until now. It seemed useful to still be able to see the versions if one just wanted to hide the banner. Therefore I opened this PR (it's been cherry-picked): Uncouple version from banner in spacemacs buffer syl20bnr#11901 syl20bnr#11901 If there's a good reason to combine them again, then the changes can be reverted.
duianto
added a commit
to duianto/spacemacs
that referenced
this pull request
Nov 30, 2019
- Removed the first line deletion. This required the banners to have an empty first line. - Removed the empty first line from the banners. - Made sure that there is a single empty line between: - The Version and Banner. - Banner and Buttons ([?] [Homepage] ...). - Version and Buttons (when the banner is hidden). - Reordered the backend version insertion function call to match the frontend Spacemacs buffer order. - version - banner - buttons Before it added: - the banner - then the buffers first line was removed - then the version was added to the first line - then the buttons were added at the bottom of the buffer (there are more things added after the buttons, but they haven't been changed by this commit). - Removed the version insertion call in: core/core-spacemacs-buffer.el The changes above caused the version to appear twice in the Spacemacs home buffer on startup. I'm not sure if it has/had other uses. This seems to be where it was first added to: core-configuration-layer.el: core: restore default mode line in home buffer syl20bnr@77161bd It was slightly modified in this commit: core: defer distro insertion in home buffer syl20bnr@cd50d9c Here it was joined with the banner: Fix version injection in home buffer Don't inject version if banner is nil syl20bnr@a764eb4 core: condensed versions into one string in left-hand side spacemacs-version@emacs-version (distribution) syl20bnr@627e934 - I had not seen that the version was joined with the banner on purpose until now. It seemed useful to still be able to see the versions if one just wanted to hide the banner. Therefore I opened this PR (it's been cherry-picked): Uncouple version from banner in spacemacs buffer syl20bnr#11901 syl20bnr#11901 If there's a good reason to combine them again, then the changes can be reverted.
smile13241324
pushed a commit
that referenced
this pull request
Dec 3, 2019
- Removed the first line deletion. This required the banners to have an empty first line. - Removed the empty first line from the banners. - Made sure that there is a single empty line between: - The Version and Banner. - Banner and Buttons ([?] [Homepage] ...). - Version and Buttons (when the banner is hidden). - Reordered the backend version insertion function call to match the frontend Spacemacs buffer order. - version - banner - buttons Before it added: - the banner - then the buffers first line was removed - then the version was added to the first line - then the buttons were added at the bottom of the buffer (there are more things added after the buttons, but they haven't been changed by this commit). - Removed the version insertion call in: core/core-spacemacs-buffer.el The changes above caused the version to appear twice in the Spacemacs home buffer on startup. I'm not sure if it has/had other uses. This seems to be where it was first added to: core-configuration-layer.el: core: restore default mode line in home buffer 77161bd It was slightly modified in this commit: core: defer distro insertion in home buffer cd50d9c Here it was joined with the banner: Fix version injection in home buffer Don't inject version if banner is nil a764eb4 core: condensed versions into one string in left-hand side spacemacs-version@emacs-version (distribution) 627e934 - I had not seen that the version was joined with the banner on purpose until now. It seemed useful to still be able to see the versions if one just wanted to hide the banner. Therefore I opened this PR (it's been cherry-picked): Uncouple version from banner in spacemacs buffer #11901 #11901 If there's a good reason to combine them again, then the changes can be reverted.
Zefrain
pushed a commit
to Zefrain/spacemacs
that referenced
this pull request
Jan 21, 2020
- Removed the first line deletion. This required the banners to have an empty first line. - Removed the empty first line from the banners. - Made sure that there is a single empty line between: - The Version and Banner. - Banner and Buttons ([?] [Homepage] ...). - Version and Buttons (when the banner is hidden). - Reordered the backend version insertion function call to match the frontend Spacemacs buffer order. - version - banner - buttons Before it added: - the banner - then the buffers first line was removed - then the version was added to the first line - then the buttons were added at the bottom of the buffer (there are more things added after the buttons, but they haven't been changed by this commit). - Removed the version insertion call in: core/core-spacemacs-buffer.el The changes above caused the version to appear twice in the Spacemacs home buffer on startup. I'm not sure if it has/had other uses. This seems to be where it was first added to: core-configuration-layer.el: core: restore default mode line in home buffer syl20bnr@77161bd It was slightly modified in this commit: core: defer distro insertion in home buffer syl20bnr@cd50d9c Here it was joined with the banner: Fix version injection in home buffer Don't inject version if banner is nil syl20bnr@a764eb4 core: condensed versions into one string in left-hand side spacemacs-version@emacs-version (distribution) syl20bnr@627e934 - I had not seen that the version was joined with the banner on purpose until now. It seemed useful to still be able to see the versions if one just wanted to hide the banner. Therefore I opened this PR (it's been cherry-picked): Uncouple version from banner in spacemacs buffer syl20bnr#11901 syl20bnr#11901 If there's a good reason to combine them again, then the changes can be reverted.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The line in the Spacemacs home buffer that shows the Spacemacs version, Emacs
version and the Spacemacs distribution, for example: "0.300.0@26.1 (spacemacs)"
were tied to the banner. The line disappeared when the banner was hidden.