Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[spacemacs-layouts] add details of restricted functions #13124

Conversation

practicalli-johnny
Copy link
Contributor

Detail how to use the layer variables to make use of restricted functions and
limit their scope to within a layout.

Documentation copied from the following commit, which did not get included along with the code
https://github.com/syl20bnr/spacemacs/tree/0e9866efcee9915f3418cec11371d02ee619ced2/layers/%2Bspacemacs/spacemacs-layouts

@practicalli-johnny practicalli-johnny force-pushed the spacemacs-layouts-readme-update branch 2 times, most recently from fde92da to 5ac1a7b Compare December 26, 2019 15:13
@practicalli-johnny
Copy link
Contributor Author

practicalli-johnny commented Dec 26, 2019

I initially forgot to add an entry in the CHANGELOG,develop. This has now been squashed and pushed.
I also found a rogue character that had sneaked into the README.org file, so deleted that and pushed.

Detail how to use the layer variables to make use of restricted functions and
limit their scope to within a layout.
@duianto
Copy link
Collaborator

duianto commented Dec 26, 2019

Thank you for contributing to Spacemacs. It's safe to delete your branch.
The changes have been applied to the develop branch.
Commit(s): b0d1585

@duianto duianto closed this Dec 26, 2019
@duianto
Copy link
Collaborator

duianto commented Dec 26, 2019

I forgot that magit strips brackets from the commit name by default, when applying a patch.

I've saved C-x C-s the Apply patches w setting:
-b Limit removal of email cruft (--keep-non-patch)
before, but I must have reinstalled since then. My bad.

@practicalli-johnny
Copy link
Contributor Author

Looking at the Spacemacs commit history, it seems most of the commits do not have the layer name in Square brackets. I didn't realise it maybe because of magit. Will have to look up that feature.

Thanks for your help.

@duianto
Copy link
Collaborator

duianto commented Dec 26, 2019

They aren't required, but it's probably helpful when there are leading brackets in the commit subject, with the layer or section (ex: [docs]). Then it's easy to see which sections the commit targets.

You did everything right, It was my mistake for not remembering to turn off the bracket removal after reinstalling Spacemacs. I wrote it down and hopefully I'll remember to check the notes during the next reinstall.

Thanks again for improving the documentation.

@practicalli-johnny practicalli-johnny deleted the spacemacs-layouts-readme-update branch April 1, 2020 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants