Fix: exiting org-present presentation always removes inline images #13205
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spacemacs configures
org-present
to inline images while presenting. That muchmakes sense. But it has a hook to turn them off unconditionally when exiting
presentation mode. This causes a problem if you just want images to show in and
out of presentation mode.
Steps to Reproduce
#+STARTUP: inlineimages
M-x org-present
Expected
Because of
#+STARTUP: inlineimages
images are still inlined.Actual
The inline images have been removed upon exiting the presentation mode.
Fix
Check
org-startup-with-inline-images
on exiting presentation mode and onlyremove the inline images if it is false.
Testing
To ensure that this did not introduce a regression of the converse behavior, I
also tested with
#+STARTUP: noinlineimages
, and it still turned off the imageswhen exiting the presentation.