[core] new function spacemacs/set-root-leader-keys-for-mode #14422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[core] This function allows to bind a mode command behind `dotspacemacs-leader-key' and `dotspacemacs-emacs-leader-key' when that mode is activate. [org] apply this function to org narrow commands motivation: Currently `spacemacs/set-leader-keys-for-major-mode` and `spacemacs/set-leader-keys-for-minor-mode` only let us bind command under `spc m` and `,` That works fine in general. But not all commands should go there. A mode that deals with compilation or comments when active should have commands bound behind `spc c` not `spc m`. Another example is org-mode narrow commands should go to prefix `spc n` not a long and tedious `spc m s b n`.
thanhvg
force-pushed
the
feature/bindingfn
branch
from
73d28a0
to
bfd7e1e
Compare
|
@syl20bnr can you comment on this PR, I am not sure if those global bindings are not breaking our conventions. If they do the least we should do is to merge the general function to allow people to use it in their personal configs. |
lebensterben
force-pushed
the
develop
branch
from
f394407
to
0bdddfc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[core] This function allows to bind a mode command behind
dotspacemacs-leader-key' anddotspacemacs-emacs-leader-key' when that mode is activate.[org] apply this function to org narrow commands
motivation:
Currently
spacemacs/set-leader-keys-for-major-modeandspacemacs/set-leader-keys-for-minor-modeonly let us bind command underspc mand,That works fine in general. But not all commands should go there. Amode that deals with compilation or comments when active should have commands
bound behind
spc cnotspc m. Another example is org-mode narrow commandsshould go to prefix
spc nnot a long and tediousspc m s b n.