[git] document configuration of Magit Forge and Git identity #15388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good. I think your website is also good but it may also be good to link to the official docs, which is the more canonical source and which will probably always up to: date https://magit.vc/manual/forge/Getting-Started.html (We should probably mention that loading the package is of course not required because it's loaded by the layer.) |
arifer612
suggested changes
Mar 2, 2022
|
I've converted to draft and will think about this some more over the next few days. Thanks. |
Ok. Please don't feel discouraged by the comments, these are really minor points and it's a great thing to add forge docs! |
practicalli-johnny
force-pushed
the
git-magit-forge-documentation
branch
from
1eda55f
to
788ec9d
Compare
practicalli-johnny
force-pushed
the
git-magit-forge-documentation
branch
from
788ec9d
to
d2171b2
Compare
arifer612
suggested changes
Mar 5, 2022
There was a problem hiding this comment.
There's still a typo in one of the links that, but other than that I think the issues that @real-or-random and I pointed out were handled!
practicalli-johnny
force-pushed
the
git-magit-forge-documentation
branch
2 times, most recently
from
2db2fa6
to
f86909b
Compare
arifer612
approved these changes
Mar 7, 2022
real-or-random
approved these changes
Mar 7, 2022
tshu-w
reviewed
Mar 8, 2022
lebensterben
reviewed
Mar 8, 2022
lebensterben
requested changes
Mar 8, 2022
practicalli-johnny
force-pushed
the
git-magit-forge-documentation
branch
from
f86909b
to
3d7c26c
Compare
real-or-random
approved these changes
Mar 10, 2022
|
Merged. Thanks for everyone. |
zv
added a commit
to zv/spacemacs
that referenced
this pull request
Apr 17, 2022
* checkversion/develop: (143 commits) fix typo (syl20bnr#15470) Remove disabled code and FIXME: resolved. (syl20bnr#15464) disable evil-surround in magit-status buffers (syl20bnr#15462) core-jump: fix incorrect lookup of :async (syl20bnr#15449) Replace alist helm sources with proper helm sources (syl20bnr#15364) Fix syl20bnr#15306. Reflect eaf layer keybinding logic to upstream changes. [lsp] Change default source of bindings back to spacemacs [core] Make startup not fail when home buffer is customised [spacemacs-editing] initialize `undo-tree-history-directory-alist` [neotree] Add zz, zt, zb bindings notmuch: Fix company based address completion (syl20bnr#15392) [bot] "documentation_updates" Mon Mar 28 11:29:34 UTC 2022 (syl20bnr#15433) [github] clarify Git configuration and authorisation documentation [org] Make org buffers work with helm-imenu-in-all-buffers [nixos] Fix variable name in README (syl20bnr#15413) [helm] fix typo in helm-ls-git (syl20bnr#15411) [completion] Fix readme markup. (syl20bnr#15410) [bot] "documentation_updates" Fri Mar 11 06:55:25 UTC 2022 (syl20bnr#15402) [git] document configuration of Magit Forge and Git identity (syl20bnr#15388) README: Added a Discord Channel ...
eraad
pushed a commit
to datil/spacemacs
that referenced
this pull request
Jun 10, 2022
…r#15388) Add documentatation to the Spacemacs Git layer describing how to configure basic git identity and more importantly how to configure Magit Forge to access GitHub / GitLab using a machine configuration and an encrypted file to hold the personal access token.
2ynn
pushed a commit
to 2ynn/spacemacs
that referenced
this pull request
Jun 22, 2022
…r#15388) Add documentatation to the Spacemacs Git layer describing how to configure basic git identity and more importantly how to configure Magit Forge to access GitHub / GitLab using a machine configuration and an encrypted file to hold the personal access token.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add documentatation to the Spacemacs Git layer describing how to configure basic git identity and more importantly how to configure Magit Forge to access GitHub / GitLab using a machine configuration and an encrypted file to hold the personal access token.