Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cumbersome pdf-tools selection behavior #15736

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions layers/+readers/pdf/packages.el
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,12 @@
:mode (("\\.pdf\\'" . pdf-view-mode))
:init
(spacemacs//pdf-tools-setup-transient-state)

(add-hook 'pdf-view-mode-hook
(lambda () (add-hook 'evil-evilified-state-entry-hook
(lambda (remove-hook 'activate-mark-hook 'evil-visual-activate-hook t))
nil t)))

:config
(progn
(pdf-tools-install)
Expand Down Expand Up @@ -63,8 +69,6 @@
"O" 'pdf-outline
"n" 'pdf-view-midnight-minor-mode)

(evil-define-key 'visual pdf-view-mode-map "y" 'pdf-view-kill-ring-save)

;; TODO: Make `/', `?' and `n' work like in Evil
(evilified-state-evilify-map pdf-view-mode-map
:mode pdf-view-mode
Expand Down Expand Up @@ -98,7 +102,8 @@
"r" 'pdf-view-revert-buffer
"o" 'pdf-links-action-perform
"O" 'pdf-outline
"zr" 'pdf-view-scale-reset)
"zr" 'pdf-view-scale-reset
"y" 'pdf-view-kill-ring-save)
(evilified-state-evilify-map pdf-outline-buffer-mode-map
:mode pdf-outline-buffer-mode
:eval-after-load pdf-outline
Expand Down