core-fonts-support: Don't fiddle with user's face Customization #16137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes syl20bnr#5353. Related: emacs-mirror/emacs@eae23d6 https://emacs.stackexchange.com/questions/33403/customize-creates-custom-set-faces-unintentionally An alternative strategy is to call `(set-frame-font fontspec nil nil)`. This will work on any emacs version, and this will also inhibit fiddling with the Customization. But this will apply the font setting only to the current frame. While this *should* be okay (because when this code runs, only the current frame should be graphical and thus relevant when it comes to font changes), I'm not convinced that this analysis is correct, and that it's a good idea to rely on this fact.
smile13241324
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5353.
Related:
emacs-mirror/emacs@eae23d6 https://emacs.stackexchange.com/questions/33403/customize-creates-custom-set-faces-unintentionally
An alternative strategy is to call
(set-frame-font fontspec nil nil). This will work on any emacs version, and this will also inhibit fiddling with the Customization. But this will apply the font setting only to the current frame. While this should be okay (because when this code runs, only the current frame should be graphical and thus relevant when it comes to font changes), I'm not convinced that this analysis is correct, and that it's a good idea to rely on this fact.