Color: Removal of nyan-mode local copy #16361
Open
+3
−1,879
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
I opened up this PR as I encountered the same issue in #12946, that
nyan-mode won't show up under doom-modeline setting. The solution
here seems to be taking advantage of the nyan-mode on MELPA, which
is essentially the one-line change in colors/packages.el. If we go down
this way, then we can take away the local copy of nyan-mode altogether.
I also checked around and removed some text mentioning nyan-mode,
but I am unsure if we are allowed to do so (for example in COPYRIGHT).
I would refer the decision up to the code owner.
Thanks in advance for reviewing bandwidth.
Hang