Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix describe-mode keybinding breaking helm #16397

Merged

Commits on May 13, 2024

  1. Fix `describe-mode' keybinding breaking helm

    This moves the existing workaround of aliasing `describe-mode' from the ivy
    layer to spacemacs-defaults. To avoid unnecessary aliasing we
    condition on the helm package being used. If it is not used, there is no problem
    with using the original `describe-mode' function.
    
    In addition, we remove the alias `lazy-helm/describe-mode' (which added an
    unnecessary (require 'helm)) from the helm layer, which originally prevented the
    issue from occuring with the helm layer on its own. With the introduction of the
    `spacemacs/describe-mode' alias it is obsolete, we do not need two aliases.
    fnussbaum committed May 13, 2024
    Configuration menu
    Copy the full SHA
    553cd48 View commit details
    Browse the repository at this point in the history