Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workarounds for stuck haskell repl #3292

Closed

Conversation

d12frosted
Copy link
Collaborator

Following #3271

  • don't move cursor back when entering normal mode in haskell REPL
  • enter insert mode when switching to haskell REPL by using
    haskell-interactive-switch function

@TheBB what do you think? I thought that setting evil-move-cursor-back to nil is enough. 馃槃

@d12frosted
Copy link
Collaborator Author

Oh. Have I broken anything about evil?

@TheBB
Copy link
Collaborator

TheBB commented Oct 7, 2015

Nah, the tests are broken on develop.

@d12frosted
Copy link
Collaborator Author

Ah. Almost good to know 馃槃

@TheBB
Copy link
Collaborator

TheBB commented Oct 7, 2015

I pushed a fix. If you rebase on top of the recent develop the tests should pass.

- don't move cursor back when entering normal mode in haskell REPL
- enter insert mode when switching to haskell REPL by using
  haskell-interactive-switch function
@d12frosted
Copy link
Collaborator Author

Done! 馃槃

@TheBB
Copy link
Collaborator

TheBB commented Oct 8, 2015

@syl20bnr should chime in on this, but I feel the advice is a no-go, just too intrusive and unexpected. The evil-move-cursor-back setting is better, but I still feel it works best as a documentation tip and not as a default. It can throw some vimmers for a loop. But... that's just my feeling.

@d12frosted
Copy link
Collaborator Author

@TheBB I see. Well I am fine with either of your decisions. Since stuck REPL is documented in the FAQ section we are already good to go. If we are not going to set evil-move-cursor-back to nil by default, then it's good idea to add this option to FAQ section as well.

As for advice... well, after I thought about it for a little more I realised that it's really not the thing to do. If you set evil-move-cursor-back to nil then there is no problems with opening REPL - you are in normal mode but the cursor is on the right place.

Update

So probably, don't merge my other PR until we decide what to do with it, so I don't spam with more PRs 馃槃

d12frosted pushed a commit to d12frosted/spacemacs that referenced this pull request Oct 10, 2015
@d12frosted
Copy link
Collaborator Author

After some time of thinking I realised that this should be really up to user. I updated README file with tips on how to use it. So closing this PR. Thanks for your input, @TheBB!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants