Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New +fun layer: selectric #4119

Closed
wants to merge 1 commit into from
Closed

New +fun layer: selectric #4119

wants to merge 1 commit into from

Conversation

algernon
Copy link
Contributor

@algernon algernon commented Dec 9, 2015

This layer makes Emacs sound like a typewriter, for those moments when one's loud, clicky mechanical keyboard is not at hand, yet, one would still wish to enjoy its sound.

@TheBB
Copy link
Collaborator

TheBB commented Dec 9, 2015

Cool layer, but I think I would like to keep SPC t t available for something a bit more important.

@StreakyCobra
Copy link
Contributor

SPC a t application typewriter

@algernon
Copy link
Contributor Author

algernon commented Dec 9, 2015

I was torn between SPC a t and SPC t t myself, too. I'll update it to SPC a t in a bit!

This layer makes Emacs sound like a typewriter, for those moments when
one's loud, clicky mechanical keyboard is not at hand, yet, one would
still wish to enjoy its sound.

Signed-off-by: Gergely Nagy <algernon@madhouse-project.org>
@syl20bnr
Copy link
Owner

syl20bnr commented Dec 9, 2015

We can introduce SPC C-t prefix for this kind of toggle.

@algernon
Copy link
Contributor Author

algernon commented Dec 9, 2015

I'm fine with that too (I'll turn it on in my ~/.spacemacs anyway, and never turn it off ;)). Let me know if you want me to update the PR.

@syl20bnr
Copy link
Owner

syl20bnr commented Dec 9, 2015

I prefer SPC C-t t since it is not really an application.

@algernon
Copy link
Contributor Author

algernon commented Dec 9, 2015

Ok. Anything else I need / should do, other than changing the binding? That is, should I add the SPC C-t prefix so it has a nice name? If yes, as part of this PR, or another?

@syl20bnr
Copy link
Owner

syl20bnr commented Dec 9, 2015

You can add the prefix name, maybe other toggles ? :-)

@CestDiego
Copy link
Contributor

I think SPC t t should have a list of all the toggles. and have them in a helm buffer. Then The macro that makes the toggle could also take into account this....sounds like a nice idea for a PR :) what about SPC t C-t for this? I think SPC C-t should be saved for something really important as well

@syl20bnr
Copy link
Owner

syl20bnr commented Dec 9, 2015

SPC C-t is not the kind of key bindings I would use for something important.
Right now we have:

  • SPC t for mode-line toggles (circled minor modes essentially)
  • SPC T for UI toggles mostly
  • SPC C-t makes sense to be for other non so common toggles.

But I agree with the idea of making SPC t t the binding to display the toggles helm source.

@algernon
Copy link
Contributor Author

algernon commented Dec 9, 2015

Aíght. I'll add SPC C-t in this PR, and change the key binding, and if time allows, I'll try my hands on the SPC t t list-all-the-toggle-stuffs PR tomorrow.

@syl20bnr
Copy link
Owner

syl20bnr commented Dec 9, 2015

@algernon FYI the helm source of toggles is already available in spacemacs-helm.el local package of spacemacs layer.

@syl20bnr
Copy link
Owner

syl20bnr commented Dec 9, 2015

Thank you ! 👍
I wanted to try it so I already merged it :-) I made some tweaks in commit eaf6b8c
Feel free to ask questions if there are things that are not clear.
Cherry-picked into develop branch, you can safely delete your branch.

@syl20bnr syl20bnr closed this Dec 9, 2015
@algernon algernon deleted the f/layers/fun/selectric branch December 10, 2015 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants