Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix early call to smartparens in ruby #4132

Closed
wants to merge 1 commit into from
Closed

Conversation

bmag
Copy link
Collaborator

@bmag bmag commented Dec 10, 2015

sp-with-modes was called before smartparens was loaded, so I wrapped it in a with-eval-after-load. I wasn't sure if this needs to go in a ruby/post-init-smartparens instead, or if smartparens should be replaced with smartparens-config as the argument to with-eval-after-load.

I don't use Ruby, so I couldn't test it. Can some Ruby user give it a try please? Should also check that the pre and post handlers definition in a Ruby file match the configuration here and are not overridden by smartparens-config.

This should fix one of the two issues encountered in #4098 - the Symbol's function definition is void: sp-with-modes error.

sp-with-modes was called before smartparens was loaded, so wrap it in a
with-eval-after-load.
@syl20bnr
Copy link
Owner

Thank you!
I simplified the configuration using a post-init function in commit f20dfec
Cherry-picked in develop branch, you can safely delete your branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants