Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Travis CI support for core tests #144 #431

Closed
wants to merge 1 commit into from

Conversation

lazywithclass
Copy link
Contributor

Added the badge to the README.md and created a travis config file.

I followed the guide for contributions, but I'm not really sure I did everything correctly about this passage:

rebase your PR branch on top of upstream develop before submitting the PR

Could you please explain it briefly?
What I did was git pull $remote develop and git chekout -b from it. I think I need another step, but it's not clear to me.

Added the badge to the README.md and created a travis config file.
@syl20bnr syl20bnr force-pushed the develop branch 2 times, most recently from be42a85 to 8582003 Compare January 15, 2015 02:50
@syl20bnr
Copy link
Owner

The rebase is only for the case when you have multiple commits in the PR.

That's great ! Now I have to take the time to code the tests :-)
Thank you 👍

Cherry-picked into the develop branch, you can safely delete your branch.

@syl20bnr syl20bnr closed this Jan 15, 2015
@lazywithclass lazywithclass deleted the travis-support branch January 15, 2015 20:18
@lazywithclass
Copy link
Contributor Author

I've seen that the badge in the README is still in the unknown state, are you having problems with that?
I've checked right now on develop and the build gets triggered fine in my account.

I'm now going to have a look at #110, let me know if there's something else I should know.

@syl20bnr
Copy link
Owner

@lazywithclass I did not activate Travis CI integration for the repo.
#110 is assigned to me but help is welcome, I'll try to make a first batch of tests for configuration-layer.el this week-end. So if you want to add some tests you can start with spacemacs-mode.el. The git related functions could be a good start. Thank you !

@lazywithclass
Copy link
Contributor Author

Ah that's perfect then. I was worried it had some problems.

I can have a look at the git functions in spacemacs-mode.el, sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants