Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add kill ring to savehist variables. #4422

Closed
wants to merge 1 commit into from

Conversation

punassuming
Copy link
Contributor

We weren't saving the kill-ring between sessions.

@tuhdo
Copy link
Contributor

tuhdo commented Jan 5, 2016

It was removed because of an issue on OSX that causes Emacs freezing. You should look at this PR as it links to the issue: #1843

@punassuming
Copy link
Contributor Author

@tuhdo, I have never had an issue with this on Windows. If this is an os specific issue, shouldn't we just have an unless check for OSX since this seems to be a saner default?

@tuhdo
Copy link
Contributor

tuhdo commented Jan 5, 2016

If we do that, then there will be inconsistency and I'm not sure if @syl20bnr is ok with that. Large kill ring can also degrade startup time since it takes longer to load all the content. Probably it's doable by limiting history length to a very small size, by following this post's suggestion: http://emacs.stackexchange.com/a/12116. But then, I think it's safer to let users decide it themselves on this to avoid potential problems.

@punassuming
Copy link
Contributor Author

I understand the position, but it seems there have been a lot of regressions in features because of isolated instances of issues in the code with the different platforms used. We have also disabled persistent undo-tree support because of a bug some people saw as well.

@nwolfe
Copy link
Contributor

nwolfe commented Jan 13, 2016

👍 for trying to make this work again. Who knows - it's been 6 months, maybe the OSX behavior is better now? 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants