Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add region state #4785

Closed

Conversation

StreakyCobra
Copy link
Contributor

There is two commits:

  • One correct the sorting in the packages list of spacemacs distribution (I was on it and syl20bnr is preparing some merge so I post it there, can be cherry-picked alone)
  • The other one add region-state package in the spacemacs distribution:

region-state

@syl20bnr
Copy link
Owner

Spaceline already displays this information ;-)

@StreakyCobra
Copy link
Contributor Author

The number of lines yes, not the number of chars. But indeed, in may be redundant for a not so wide usage.

@syl20bnr
Copy link
Owner

The number of chars can be added.
One advantage of this package is that it is always visible, the mode-line segment may be invisible. OTOH we could move the segment to the left.

@StreakyCobra
Copy link
Contributor Author

It's up to you, both are fine for me.

@StreakyCobra
Copy link
Contributor Author

From @TheBB on gitter:

I don't mind moving it out of the modeline actually.
Segments that don't show still cost in terms of performance. And the modeline updates quite frequently, and spaceline is already not so fast.
May need to optimize a bit.

@syl20bnr
Copy link
Owner

Ok let's remove it from spaceline and use this package instead

@StreakyCobra
Copy link
Contributor Author

Updated to remove the spaceline segment.

I just noticed that the message in the echo area is overridden sometimes, like by the function definition under the cursor in elisp files, so… the current situation is maybe better. I let you decide on this, close the PR if we keep the current way.

@syl20bnr syl20bnr self-assigned this Jul 4, 2016
@syl20bnr syl20bnr removed their assignment May 22, 2017
@TheBB
Copy link
Collaborator

TheBB commented Jun 18, 2017

Since spaceline does this and is faster now, I think it's safe to close this PR. Thanks!

@TheBB TheBB closed this Jun 18, 2017
@StreakyCobra StreakyCobra deleted the feature/region-state branch June 18, 2017 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants