Google translate refactor #4912
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You're going to need to rebase by the way since #4893 was merged |
|
As was #4829. :-P |
lislon
force-pushed
the
google-translate-refactor
branch
from
d5f4ea2
to
1210986
Compare
- Suit spacemacs-language layer to new layout - Don't explicitly list commands (they are autoloaded) - Move xgl binding from keybindings.el - Don't explicitly require the default-ui feature (not necessary) - Set variables in init instead of config (easier to change for users) Credits to TheBB for initial PR
lislon
force-pushed
the
google-translate-refactor
branch
from
1210986
to
a05d0dd
Compare
|
👍 |
|
#4947 having been merged, this one need a rebase :-) Shouldn't be difficult though. |
|
I'll have to come back to this in the future release. |
|
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please let us know if this PR is still need merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
google-translate refactoring
Credits to @TheBB for initial PR #4829
Fixes #4827.