-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mu4e - better defaults, async and utility functions #4936
Conversation
@peterhoeg amend the commit message to be descriptive about what this change was...because a lot of people look at commits to see what changed and when. If you use magit, then it's |
thank you @robbyoconnor for your patience. |
👍 I'm just a guy who occasionally looks at pull requests/issues and ensures they follow conventions :) |
layers/+email/mu4e/config.el
Outdated
@@ -15,5 +15,8 @@ | |||
(defvar mu4e-account-alist nil | |||
"Account alist for custom multi-account compose.") | |||
|
|||
(defvar mu4e-async nil |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rename it mu4e-enable-async-operations
and be more explicit about what it does in the docstring (for now only sending message asynchronously)
@peterhoeg Thanks for the PR, don't forget to document what you add, like the new layer variable. |
Perhaps this belongs in a different issue/PR, but since this one is about better defaults... A recent commit changed the behavior of This doesn't really make sense to me, as the default binding that mu4e provides is |
Sure thing, sorry I missed that issue earlier. I'll follow up there. Fabien Dubosson writes:
|
This PR does a few things: - supports async mode for sending mails - registers imagemagick as handler for images if it exists - sets default downloads directory if it exists - sets a few (more) sane defaults - supports format=flowed in messages
It took a little longer than expected, but this is the revised version based on feedback from everyone. |
Thank you ! 👍 |
Single commit version of #4841 as requested by @syl20bnr