Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mu4e - better defaults, async and utility functions #4936

Closed
wants to merge 1 commit into from
Closed

mu4e - better defaults, async and utility functions #4936

wants to merge 1 commit into from

Conversation

peterhoeg
Copy link
Contributor

Single commit version of #4841 as requested by @syl20bnr

@robbyoconnor
Copy link
Contributor

@peterhoeg amend the commit message to be descriptive about what this change was...because a lot of people look at commits to see what changed and when. If you use magit, then it's c followed by a and then just force-push to this branch and it will be reflected here.

@peterhoeg
Copy link
Contributor Author

thank you @robbyoconnor for your patience.

@robbyoconnor
Copy link
Contributor

👍 I'm just a guy who occasionally looks at pull requests/issues and ensures they follow conventions :)

@@ -15,5 +15,8 @@
(defvar mu4e-account-alist nil
"Account alist for custom multi-account compose.")

(defvar mu4e-async nil
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rename it mu4e-enable-async-operations and be more explicit about what it does in the docstring (for now only sending message asynchronously)

@syl20bnr
Copy link
Owner

@peterhoeg Thanks for the PR, don't forget to document what you add, like the new layer variable.
Also I'm going to push some PR for mu4e, be prepared to rebase.

@kostajh
Copy link
Contributor

kostajh commented Feb 17, 2016

Perhaps this belongs in a different issue/PR, but since this one is about better defaults... A recent commit changed the behavior of J from mu4e~headers-jump-to-maildir to mu4e-headers-mark-thread nil.

This doesn't really make sense to me, as the default binding that mu4e provides is j (lowercase), as you can see when you first launch mu4e. Keeping that binding to J made a lot of sense. Could we add that back if others agree? Happy to open an issue if you don't want to deal with this here.

@StreakyCobra
Copy link
Contributor

@kostajh Can you please discuss this there: #4490? Most people interested by mu4e are already discussing the keybindings there.

@kostajh
Copy link
Contributor

kostajh commented Feb 17, 2016

Sure thing, sorry I missed that issue earlier. I'll follow up there.

Fabien Dubosson writes:

@kostajh Can you please discuss this there: #4490? Most people interested by mu4e are already discussing the keybindings there.


Reply to this email directly or view it on GitHub:
#4936 (comment)

@kostajh | kosta@kostaharlan.net

This PR does a few things:

- supports async mode for sending mails
- registers imagemagick as handler for images if it exists
- sets default downloads directory if it exists
- sets a few (more) sane defaults
- supports format=flowed in messages
@peterhoeg
Copy link
Contributor Author

It took a little longer than expected, but this is the revised version based on feedback from everyone.

@syl20bnr
Copy link
Owner

Thank you ! 👍
Cherry-picked into develop branch, you can safely delete your branch.

@syl20bnr syl20bnr closed this Jan 20, 2018
@syl20bnr syl20bnr removed the Merged label Jan 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants