scala: make some keybindings work in emacs editing style #4957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the keybindings in the scala layer are defined with `evil-define-key` for `insert` state. Since evil mode is no longer activated in emacs editing style, these keybindings don't work.
|
Putting this PR on hold, it may be unnecessary since I plan to put back evil in holy mode. |
|
👍 |
|
@moonranger @syl20bnr Can this be closed? I'm not entirely sure what holy mode is, but it seems like it uses evil again. |
| (kbd "M-.") 'ensime-edit-definition | ||
| (kbd "M-,") 'ensime-pop-find-definition-stack) | ||
| (define-key ensime-mode-map (kbd ".") 'scala/completing-dot) | ||
| (define-key ensime-mode-map (kbd "M-.") 'ensime-edit-definition) |
There was a problem hiding this comment.
When using M-. does it drop you in insert mode?
|
Sorry I've not been using spacemacs for a while and I'm not sure if this change is still relevant. I'll close it for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the keybindings in the scala layer are defined with
evil-define-keyforinsertstate. Since evil mode is no longeractivated in emacs editing style, these keybindings don't work.