Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an example hook to evil-cleverparens layer doc #5569

Closed
wants to merge 1 commit into from

Conversation

gilch
Copy link
Contributor

@gilch gilch commented Mar 23, 2016

Add an example clojure-mode-hook and remove misstatement

The layer doesn't add a hook to load with emacs-lisp-mode. A hook is required in the dotfile.

@bmag
Copy link
Collaborator

bmag commented Mar 23, 2016

FWIW, I use this to enable evil-cleverparens:

(add-hook 'smartparens-enabled-hook #'spacemacs/toggle-evil-cleverparens-on)
(add-hook 'smartparens-disabled-hook #'spacemacs/toggle-evil-cleverparens-off)

@gilch
Copy link
Contributor Author

gilch commented Mar 23, 2016

Updating the doc is a minimal fix, but perhaps not an optimal one. I'm not sure, but if it generally makes sense to enable evil-cleverparens anytime smartparens is active, wouldn't it be better to add those hooks to the layer instead so the user doesn't have to configure it?

@gilch gilch changed the title Add an example hook Add an example hook to evil-cleverparens layer doc Mar 23, 2016
@bmag
Copy link
Collaborator

bmag commented Mar 23, 2016

That's a good suggestion. You're welcome to modify the PR 😉

@gilch
Copy link
Contributor Author

gilch commented Mar 23, 2016

I think it would be better in a new PR, since it would also require an update of this doc, but completely unrelated to my changes so far. It's not clear to me if that's a good default or not. Is smartparens only used for lisps? Does evil-cleverparens make sense in a non-lisp language? I needs its own discussion, even if you just open an issue. I'll close this PR if your PR gets merged first, since it would be obsolete, but if this gets merged first, no harm done, since you'll have to rewrite the doc anyway.

@StreakyCobra
Copy link
Contributor

Thank you 👍 Cherry-picked into develop, you can safely delete your branch.

@StreakyCobra StreakyCobra removed their assignment Apr 5, 2016
@gilch gilch deleted the patch-2 branch January 26, 2017 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants