Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #5953, pcre2el should be a post-init in spacemacs-editing. #5990

Closed
wants to merge 1 commit into from

Conversation

punassuming
Copy link
Contributor

This gets rid of the warning on load. spacemacs-base will always be loaded, regardless of the distribution used. Call in spacemacs-editing will add keybindings.

@TheBB
Copy link
Collaborator

TheBB commented May 6, 2016

This won't do it. Now nobody without ivy will get pcre2el functionality. There should be an init function in a very basic layer and then both ivy and editing should have post-init functions.

@punassuming
Copy link
Contributor Author

Yes you are right, I will fix this.

@punassuming
Copy link
Contributor Author

punassuming commented May 9, 2016

@StreakyCobra, @TheBB, I updated this PR to put the primary init in spacemacs-base. Since base will always be loaded, we shouldn't have any issues with ivy anymore.

@punassuming
Copy link
Contributor Author

punassuming commented May 19, 2016

@syl20bnr , I noticed your comments in the source about this. We need to load pcre2el in the base as it is used outside of just spacemacs-editing. For example, ivy also needs it with our custom counsel-search function which uses rxt-quote-pcre, also it is used in helm layer.

@syl20bnr
Copy link
Owner

Thank you ! 👍
I changes the invasive SPC R prefix for pcre2el to SPC x r, it allowed me to move safely the whole configuration (key bindings) of pcre2el to spacemacs-base.
Cherry-picked into develop branch, you can safely delete your branch.

@syl20bnr syl20bnr closed this Jun 13, 2016
@syl20bnr syl20bnr removed the Merged label Jun 13, 2016
bmag added a commit that referenced this pull request May 10, 2018
pcre2el is used by several layers, such as ivy and helm, so it needs to be
available outside of spacemacs-editing layer.
See also #5990 (comment)
alanjferguson pushed a commit to alanjferguson/spacemacs that referenced this pull request May 14, 2018
pcre2el is used by several layers, such as ivy and helm, so it needs to be
available outside of spacemacs-editing layer.
See also syl20bnr#5990 (comment)
buckarooch pushed a commit to profilech/.emacs.d that referenced this pull request May 19, 2018
pcre2el is used by several layers, such as ivy and helm, so it needs to be
available outside of spacemacs-editing layer.
See also syl20bnr#5990 (comment)
CodingSolo pushed a commit to CodingSolo/spacemacs that referenced this pull request Oct 29, 2018
pcre2el is used by several layers, such as ivy and helm, so it needs to be
available outside of spacemacs-editing layer.
See also syl20bnr#5990 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants