-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #5953, pcre2el should be a post-init in spacemacs-editing. #5990
Conversation
This won't do it. Now nobody without ivy will get pcre2el functionality. There should be an init function in a very basic layer and then both ivy and editing should have post-init functions. |
Yes you are right, I will fix this. |
@StreakyCobra, @TheBB, I updated this PR to put the primary init in |
5d0890d
to
9f6ed9c
Compare
@syl20bnr , I noticed your comments in the source about this. We need to load pcre2el in the base as it is used outside of just |
Thank you ! 👍 |
pcre2el is used by several layers, such as ivy and helm, so it needs to be available outside of spacemacs-editing layer. See also #5990 (comment)
pcre2el is used by several layers, such as ivy and helm, so it needs to be available outside of spacemacs-editing layer. See also syl20bnr#5990 (comment)
pcre2el is used by several layers, such as ivy and helm, so it needs to be available outside of spacemacs-editing layer. See also syl20bnr#5990 (comment)
pcre2el is used by several layers, such as ivy and helm, so it needs to be available outside of spacemacs-editing layer. See also syl20bnr#5990 (comment)
This gets rid of the warning on load. spacemacs-base will always be loaded, regardless of the distribution used. Call in spacemacs-editing will add keybindings.