[react layer] Project wide jump to definition #6164
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's really cool, I need to delay the PR a bit because I'm thinking about dumb-jump, maybe we should make it part of the tag layer revamp. |
|
just an update: with the last releases of dumb-jump it now works as expected with jsx components as well |
|
After #6851 this should be in now. Let me know if not (you may have to define |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dumb-jump seems to do a great work with javascript and finally allow a decent project wide jump to definition.
For now I'm keeping tern keybindings as the behavior is different for searching on same buffer and by name.
I've also opened an issue on dumb-jump to see if we can end up recognizing jsx components and their definitions.