Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show ielm in a popwin buffer, default in insert-mode. #6396

Closed
wants to merge 1 commit into from

Conversation

punassuming
Copy link
Contributor

Get ielm to work with popwin. Default to insert-mode if evil is active.

@syl20bnr syl20bnr self-assigned this Jul 4, 2016
@bmag
Copy link
Collaborator

bmag commented Aug 24, 2016

I voted against because (1) I tend to use IELM as a normal interactive shell, the same as I would use a Python terminal, so using popwin and hiding the buffer on C-g would be uncomfortable, and (2) because it's inconsistent with all other terminals and REPLs (at least those that I've used), except for the shell layer's shells.

@d12frosted
Copy link
Collaborator

@syl20bnr is it still in merging state? 😸 I don't see it on develop.

@syl20bnr
Copy link
Owner

syl20bnr commented Nov 7, 2016

Thank you!

I was merging it and I asked myself the same questions as @bmag, I came here to comment and saw @bmag's comment so I'm for not merging this one for the sake of consistency with the other REPLs.

@syl20bnr syl20bnr closed this Nov 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants