Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore eww created url directory #6402

Closed
wants to merge 1 commit into from
Closed

Ignore eww created url directory #6402

wants to merge 1 commit into from

Conversation

what-the-functor
Copy link
Contributor

Eww creates a url directory inside of .emacs.d. This prevents updates because the git status is not clean.

@syl20bnr
Copy link
Owner

Do you use the develop branch or does the url directory come from the master branch ? This directory should be fixed in develop branch so it is not necessary to add it to the gitignore file.

@what-the-functor
Copy link
Contributor Author

what-the-functor commented Jun 23, 2016

@syl20bnr, I use the master branch. This directory is created when the user loads a page in eww, and presumably when they user views a git reference in magit (magit displays the committer's gravatar).

@syl20bnr
Copy link
Owner

syl20bnr commented Jul 3, 2016

I cannot reproduce it. Are you able to reproduce it with a clean installation ? Do you think it is possible that the url directory has been created a long time ago while it was not set by Spacemacs ?
Do you have a url directory in the .cache directory ?

@what-the-functor
Copy link
Contributor Author

what-the-functor commented Jul 3, 2016

I can reproduce this by viewing a git commit with Magit. In the Magit Log buffer, place the cursor on a reference, and press enter. I specifically reproduced this, by viewing 0283f64 in the spacemacs repo.

The following file is created within ".emacs.d": "url/cache/$user/http/com/gravatar/www/$guid".

@what-the-functor
Copy link
Contributor Author

Another way to reproduce this is to load a web page using eww.

@syl20bnr
Copy link
Owner

syl20bnr commented Jul 4, 2016

You are able to reproduce it with a clean Spacemacs and .spacemacs file? All the files you mentioned here are in .cache directory for me.

@what-the-functor
Copy link
Contributor Author

I just tried with a clean Spacemacs install, and fresh .spacemacs file.

  • Rename .spacemacs.
  • Quit emacs, and delete ~/.emacs.d.
  • Clone Spacemacs to ~/.emacs.d.
  • Launch emacs (emacs-plus 24.5).
  • Select evil mode.
  • After compilation, quit emacs, and re-launch.
  • Add 'git' layer to 'dotspacemacs-configuration-layers' (no other changes to .spacemacs), and reload.
  • View git status of ~/.emacs.d in magit: spc u, spc g s, select ~/.emacs.d
  • View log: spc g l l
  • View the commit at HEAD: press enter/return
    This is the point where the url directory is created within ~/.emacs.d. A cache entry is created for the author's, and committer's gravatar.

@syl20bnr
Copy link
Owner

syl20bnr commented Jul 7, 2016

Thank you for the great steps, I will check them soon.

@joehillen
Copy link
Contributor

This is still happening on develop

@syl20bnr syl20bnr self-assigned this Apr 29, 2017
@syl20bnr
Copy link
Owner

Thank you !
I have it occasionally and I cannot reproduce it consistently so let's ignore it.
Cherry-picked into develop branch, you can safely delete your branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants