-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate mmm-modes automatically based on a list #6579
Conversation
Shouldn't there be a more DRY way of supporting all languages (or at least all languages from a given list)? |
I don't think there's a fully automated way. But maybe something like this? I'm on it... |
Yes, this looks definitely less boilerplaty. |
Includes a config variable for use in `dotspacemacs-configuration-layers`
@@ -42,6 +42,18 @@ | |||
(defun markdown/post-init-smartparens () | |||
(add-hook 'markdown-mode-hook 'smartparens-mode)) | |||
|
|||
;; from Jason Blevins http://jblevins.org/log/mmm | |||
(defun markdown/mmm-auto-class (lang &optional submode) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be spacemacs//markdown-mmm-auto-class
, shouldn't it?
I would also like a small section in |
There is. |
My bad, was looking at master branch. LGTM. |
where the mode name is different from the language name
d439083 just turned this from "meh" to ugly. But hey, it works and removes an additional manual config step. If someone has an idea how to handle this better, you know what to do. |
That's not ugly! |
Thank you ! 💜 |
This "fixes" #6571
Question:
Should we really add all possible combinations of languages, or let the user (Spacemacsian) take care of that themselves?
If we keep adding definitions to the core, we'll end up with a terribly long list...