Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add permalinks to the doc headings #6747

Closed
wants to merge 1 commit into from

Conversation

nashamri
Copy link
Contributor

@nashamri nashamri commented Aug 2, 2016

This PR is to add permalinks to the documentation headings and sections to make it easy to share links and to fix this website issue syl20bnr/spacemacs.org#13.

@TheBB TheBB added this to the release 0.200 milestone Aug 5, 2016
@TheBB
Copy link
Collaborator

TheBB commented Aug 22, 2016

This won't work because the HTML files aren't all at the same depth. :-/

@nashamri
Copy link
Contributor Author

I can't think of any way to overcome this other than just using the full path to that javascript file. It's already on http://develop.spacemacs.org/js/permalinks.js

Should I just change it to be http://www.spacemacs.org/js/permalinks.js (the stable site)?

@TheBB TheBB removed this from the release 0.200 milestone Sep 7, 2016
@nashamri
Copy link
Contributor Author

I added the absolute path to that js file. It's not on the stable branch yet but on the develop branch of the website. If this is okay, we can move that file to the stable branch.

@JAremko
Copy link
Collaborator

JAremko commented Sep 17, 2016

can't think of any way to overcome this other than just using the full path to that javascript file.

@nashamri Can You use the same trick as with the css readtheorg injection ?

https://github.com/nashamri/spacemacs/blob/21cfdf8b040c73fe01ede2dfaec60eb826d472a2/core/core-documentation.el#L152

@syl20bnr syl20bnr self-assigned this Apr 29, 2017
@syl20bnr
Copy link
Owner

Thank you ! 👍
For now the absolute path will do it. We can go the injection route later (or when it breaks 😁).
Cherry-picked into develop branch, you can safely delete your branch.

@syl20bnr syl20bnr closed this Apr 29, 2017
@syl20bnr syl20bnr removed the Merged label Apr 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants