Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace org-set-tags when ivy layer is used #6993

Closed
wants to merge 1 commit into from

Conversation

darkfeline
Copy link
Contributor

@darkfeline darkfeline commented Sep 2, 2016

When ivy is used, the default org-set-tags will only complete for the
first tag, and any additional tags must be typed manually. counsel
provides a replacement function to fix this.

See #6918

@TheBB
Copy link
Collaborator

TheBB commented Sep 2, 2016

Can you move this to a post-init-ivy function?

@darkfeline
Copy link
Contributor Author

darkfeline commented Sep 3, 2016

Since the alias is overriding an org symbol, if I put it in post-init-ivy, wouldn't loading org overwrite the alias? Example:

  • ivy is loaded
  • alias gets set
  • org is loaded
  • alias get overwritten

vs

  • (stuff happens)
  • org is loaded
  • alias gets set
  • (stuff happens)

When ivy is used, the default org-set-tags will only complete for the
first tag, and any additional tags must be typed manually.  counsel
provides a replacement function to fix this.

Unfortunately, we can't just alias org-set-tags because it is used in
other places, so we must change C-c C-c using a hook.

See syl20bnr#6918
@syl20bnr
Copy link
Owner

syl20bnr commented Jan 8, 2018

Thank you ! 👍

I changed the config for a post-init-org function in commit 14b20649

Cherry-picked into develop branch, you can safely delete your branch.

@syl20bnr syl20bnr closed this Jan 8, 2018
@syl20bnr syl20bnr removed the Merged label Jan 8, 2018
@darkfeline darkfeline deleted the counsel-org-tag branch January 9, 2018 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants