Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common Lisp: enable fuzzy matching with comapny #7018

Closed
wants to merge 1 commit into from

Conversation

tuhdo
Copy link
Contributor

@tuhdo tuhdo commented Sep 4, 2016

No description provided.

@TheBB
Copy link
Collaborator

TheBB commented Sep 5, 2016

Dude, link please.

#7019

@tuhdo
Copy link
Contributor Author

tuhdo commented Sep 5, 2016

Well that issue is different. It addresses fuzzy matching with capf in general, while this package uses the specialized fuzzy matcher from SLIME (not capf).

@TheBB
Copy link
Collaborator

TheBB commented Sep 5, 2016

Okay, sorry.

@@ -33,6 +34,10 @@
(defun common-lisp/post-init-helm-gtags ()
(spacemacs/helm-gtags-define-keys-for-mode 'common-lisp-mode))

(defun common-lisp/init-slime-company ()
:config
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I use :config to delay setting of the variable until the package is loaded. That is, when the variable is available.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, but it goes in use-package. Defun doesn't understand it.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides there's no need to delay setting variables until the defvar has happened, for that matter.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh it's a typo. I deleted the line use-package somehow.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I deleted use-package, but left :config behind. I've updated.

@tuhdo
Copy link
Contributor Author

tuhdo commented Sep 5, 2016

I updated the PR.

@AndreaOrru
Copy link

AndreaOrru commented Oct 13, 2016

Is this going to be merged?

@TheBB
Copy link
Collaborator

TheBB commented Oct 17, 2016

Thanks! Cherry-picked in develop. You can safely delete your branch.

@TheBB TheBB closed this Oct 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants