Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add language layer for Protocol Buffers. #7027

Closed
wants to merge 1 commit into from
Closed

Add language layer for Protocol Buffers. #7027

wants to merge 1 commit into from

Conversation

amol-mandhane
Copy link

Resolves #6973

@TheBB
Copy link
Collaborator

TheBB commented Sep 5, 2016

Thanks, but both those packages are on MELPA. You don't need the recipes.

@TheBB TheBB added the New Layer label Sep 5, 2016
@amol-mandhane
Copy link
Author

Updated the packages.

@amol-mandhane
Copy link
Author

Ping. Any other changes required in this PR?

@amol-mandhane
Copy link
Author

Hi. Does the layer look good to merge?

@d12frosted
Copy link
Collaborator

Hey,

Usully new layers are merged directly by Sylvain, but he is quite busy with
upcoming release, so this PR might wait a little longer before getting to
develop.

Cheers,
Boris

On September 20, 2016 at 11:04:23 PM, Amol Mandhane (
notifications@github.com) wrote:

Hi. Does the layer look good to merge?


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#7027 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AGNNiQ-ZAvFyx3R-MS8ZuOuvsl3OouKhks5qsDxHgaJpZM4J098g
.

;;
;;; License: GPLv3

(setq protobuf-packages '(protobuf-mode flycheck-protobuf))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The usual coding style for almost all of the other layers is to write the package names under the *-packages variable name, one per line, with the parentheses on separate lines.

Copy link
Author

@amol-mandhane amol-mandhane Oct 10, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Copied the style change from auto-completion layer.

@edrex edrex mentioned this pull request Nov 7, 2016
2 tasks
Copy link
Contributor

@edrex edrex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to remove the flycheck-proto dependency and enable flycheck-mode by default. Other than that looks good to me.

(setq protobuf-packages
'(
protobuf-mode
flycheck-protobuf
Copy link
Contributor

@edrex edrex Dec 16, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Protobuf checking is now available in flycheck itself, see
flycheck/flycheck#1125. The flycheck-protobuf package is no longer in MELPA (melpa/melpa#4382) so this dependency should be removed.

(flycheck-mode) works for me in a protobuf buffer, but it seems like it should be enabled automatically if flycheck is installed.

@edrex edrex mentioned this pull request Jan 22, 2017
@edrex
Copy link
Contributor

edrex commented Jan 22, 2017

I've opened another PR, #8234, with the changes requested in my feedback. Let's get that merged.

@syl20bnr
Copy link
Owner

syl20bnr commented Apr 9, 2017

Thank you ! 👍
Cherry-picked into develop branch, you can safely delete your branch.

@syl20bnr syl20bnr closed this Apr 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants