-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add language layer for Protocol Buffers. #7027
Conversation
Thanks, but both those packages are on MELPA. You don't need the recipes. |
Updated the packages. |
Ping. Any other changes required in this PR? |
Hi. Does the layer look good to merge? |
Hey, Usully new layers are merged directly by Sylvain, but he is quite busy with Cheers, On September 20, 2016 at 11:04:23 PM, Amol Mandhane (
|
;; | ||
;;; License: GPLv3 | ||
|
||
(setq protobuf-packages '(protobuf-mode flycheck-protobuf)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The usual coding style for almost all of the other layers is to write the package names under the *-packages variable name, one per line, with the parentheses on separate lines.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Copied the style change from auto-completion layer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs to remove the flycheck-proto
dependency and enable flycheck-mode by default. Other than that looks good to me.
(setq protobuf-packages | ||
'( | ||
protobuf-mode | ||
flycheck-protobuf |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Protobuf checking is now available in flycheck itself, see
flycheck/flycheck#1125. The flycheck-protobuf package is no longer in MELPA (melpa/melpa#4382) so this dependency should be removed.
(flycheck-mode)
works for me in a protobuf buffer, but it seems like it should be enabled automatically if flycheck is installed.
I've opened another PR, #8234, with the changes requested in my feedback. Let's get that merged. |
Thank you ! 👍 |
Resolves #6973