Add: org-journal support

[nickanderson]

No description provided.

[nixmaniack]

This looks redundant when you are using :toggle for package selection.

[nickanderson]

Anything else that I should fix for this?

[nixmaniack]

Maintainers will review it further before it gets added to develop. Since they're busy these days preparing new stable release, any new package/feature addition might get delayed(I think).

[nickanderson]

Ok, no problem thanks

[autosquid]

bump. will this be ok to be merged? seemingly a great feature.

[jgmize]

@nickanderson thanks for your work on this. Would you mind rebasing on the current develop branch and resolving the merge conflicts?

[nickanderson]

Surething

[jgmize]

I tested this locally and it worked like a charm. I also updated my spacemacs-tmux docker image to use this branch, so if you're interested in testing it without altering your local spacemacs config try the following:

docker run -it quay.io/jgmize/spacemacs-tmux

[nickanderson]

Oh, so this org-journal-dir and org-journal-file-format are my own preferences, they seem to have snuk in. Shall I remove those so that they can be set in user-config?

The default value for org-journal-dir is ~/Documents/journal/ and the default file format is YYYYMMDD

[jgmize]

I like your defaults better than the package defaults; perhaps just add docs for how to configure them in .spacemacs?

[nickanderson]

Rebased, removed my defaults updated docs.

[jgmize]

I tested out your latest updates, including setting the org-journal-dir and org-journal-file-format variables and I got the following error when I opened a new journal entry with SPC a o j n:

Auto-evilication could not remap these functions in map `org-agenda-mode-map': 
   - `org-agenda-filter-by-tag-refine' originally mapped on `\'           

[nickanderson]

Well that's a shame.

@jgmize Did you verify that org-journal-dir existed?

[jgmize]

Yes, and it opened an existing journal file I had created earlier. I should have mentioned that the message was a warning than a blocker, after dismissing it things worked as expected.

[nickanderson]

Ok, so some keybinding didnt get automatically remapped. I don't see it as an issue, but warnings are annoying. Is there some way to avoid it?

[nickanderson]

I aligned the new journal entry keybindings. Now its SPC o a j j for the main spacemacs binding and SPC m j in org-journal mode.

[jgmize]

The latest changes have been working well for me: no more warnings and the new keybindings work as expected. Thanks again for your work on this @nickanderson, and hopefully someone with commit access will be able to take a look at this before another merge conflict is introduced.

[nickanderson]

Great, thanks for the feedback @jgmize. I can always re-base if a conflict arises :).

[d12frosted]

Thank you 👍 Cherry-picked into develop, you can safely delete your branch. @nickanderson ❤️

Folks, go ahead and enjoy 😸

---

I've made several changes in 0477040:

• Use commands to expose globally bound functions in order to make them working with lazy loading.
• Fixed indentation issues - do not forget to properly indent 😸 and DON'T use tabs.

[nickanderson]

thanks @d12frosted !