Use Magit 2.8's built-in fullscreen status display function #7085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -358,7 +358,7 @@ Press [_b_] again to blame further in the history, [_q_] to go up or quit." | |||
| 'spacemacs/magit-toggle-whitespace) | |||
| ;; full screen magit-status | |||
| (when git-magit-status-fullscreen | |||
| (setq magit-display-buffer-function 'spacemacs//fullscreen-magit))))) | |||
| (setq magit-display-buffer-function 'magit-display-buffer-fullframe-status-v1))))) | |||
There was a problem hiding this comment.
Maybe we can do away with the layer variable altogether and just document this one instead?
There was a problem hiding this comment.
Yes that's possible. Also those documentation sections in the README could also be cleaned up a bit as well to use the layer variable system rather than defining them in user-init
There was a problem hiding this comment.
Any thoughts about how to proceed with this PR?
|
Thanks! Cherry-picked in develop. Let's keep it like this for now. You can safely delete your branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Magit 2.8(changelog here https://emacsair.me/2016/08/21/magit-2.8/) added it's own set of display functions one of which is a fullscreen display function that acts the same way as Spacemacs' version. These are documented here https://magit.vc/manual/magit/Switching-Buffers.html. This removes the need for Spacemacs to maintain its own version of a fullscreen status function.