Yaml layer: enable flycheck #7153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheBB
requested changes
Sep 20, 2016
| (defun yaml/init-yaml-mode () | ||
| "Initialize YAML mode" | ||
| (use-package yaml-mode | ||
| :defer t |
There was a problem hiding this comment.
:mode implies :defer, so no need for this.
There was a problem hiding this comment.
oh, i see, one sec then
rski
changed the title
TheBB
requested changes
Sep 20, 2016
TheBB
approved these changes
Sep 20, 2016
|
@TheBB -- actually all flycheck checkers require external tools. Literally all flycheck does is parse the output from the various tools... |
d12frosted
reviewed
Oct 12, 2016
| @@ -1,4 +1,4 @@ | |||
| ;;; config.el --- YAML Layer packages File for Spacemacs | |||
| ;;; config.el --- YAML Layer configuration File for Spacemacs | |||
There was a problem hiding this comment.
Thanks for fixing this line. But it should be config 😸
There was a problem hiding this comment.
I can fix it, but I just looked it up from other layers :-)
~/Code/spacemacs/spacemacs on yaml_flycheck ⌚ 20:34:53
$ ag "config file"| wc -l
11
~/Code/spacemacs/spacemacs on yaml_flycheck ⌚ 20:35:00
$ ag "configuration file"| wc -l
67
|
Thank you 👍 Cherry-picked into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.